From mboxrd@z Thu Jan  1 00:00:00 1970
From: Troy Kisky <troy.kisky@boundarydevices.com>
Date: Mon, 31 Mar 2014 11:36:55 -0700
Subject: [U-Boot] [PATCH 1/1] imx-common: cpu: add fdt_file environment
	variable
In-Reply-To: <53375325.1080402@boundarydevices.com>
References: <1396132481-9446-1-git-send-email-troy.kisky@boundarydevices.com>
	<53375325.1080402@boundarydevices.com>
Message-ID: <5339B5C7.3090604@boundarydevices.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 3/29/2014 4:11 PM, Eric Nelson wrote:
> Hi Troy,
> 
> On 03/29/2014 03:34 PM, Troy Kisky wrote:
>> This removes one block in the move toward 1 u-boot
>> for both a mx6q (quad) and mx6dl (duallite) processor.
>>
>> Now fdt_file hardcoded value can be removed.
>>
>> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
>> ---
>>   arch/arm/imx-common/cpu.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
>>   arch/arm/lib/board.c      |  7 +++++++
>>   2 files changed, 51 insertions(+)
>>
>> diff --git a/arch/arm/imx-common/cpu.c b/arch/arm/imx-common/cpu.c
>> index a77c4de..5d48011 100644
>> --- a/arch/arm/imx-common/cpu.c
>> +++ b/arch/arm/imx-common/cpu.c
>> @@ -180,3 +180,47 @@ void arch_preboot_os(void)
>>       ipuv3_fb_shutdown();
>>   }
>>   #endif
>> +
>> +const char *get_dtb_prefix(u32 imxtype)
>> +{
>> +    switch (imxtype) {
>> +    case MXC_CPU_MX6Q:
>> +    case MXC_CPU_MX6D:
>> +        return "imx6q";        /* Quad/Dual-core version of the mx6 */
>> +    case MXC_CPU_MX6DL:
>> +    case MXC_CPU_MX6SOLO:
>> +        return "imx6dl";    /* Dual Lite/Solo version of the mx6 */
>> +    case MXC_CPU_MX6SL:
>> +        return "imx6sl";    /* Solo-Lite version of the mx6 */
>> +    case MXC_CPU_MX51:
>> +        return "imx51";
>> +    case MXC_CPU_MX53:
>> +        return "imx53";
>> +    }
>> +    return "??";
>> +}
>> +
> 
> I really dislike this implementation of naming policy in code.


It is not truly a policy. It is a convenience which can be ignored
if so desired. Though I do agree that cpu and board environment variables
would also be useful. Still, a cpu variable would still require
some scripting to combine the quad/dual, duallite/solo. So, your
way is not as convenient for dtb file names.


Troy