u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/3] ARM: Add workaround for Cortex-A9 errata 794072
Date: Wed, 02 Apr 2014 17:26:13 +0200	[thread overview]
Message-ID: <533C2C15.6030400@denx.de> (raw)
In-Reply-To: <1396446903-7967-2-git-send-email-nitin.garg@freescale.com>

Hi Nitin,

On 02/04/2014 15:55, nitin.garg at freescale.com wrote:
> From: Nitin Garg <nitin.garg@freescale.com>
> 
> A short loop including a DMB instruction might cause a denial of
> service on another processor which executes a CP15 broadcast operation.
> Exists on r1, r2, r3, r4 revisions.
> 
> Signed-off-by: Nitin Garg <nitin.garg@freescale.com>
> Acked-by: Dirk Behme <dirk.behme@de.bosch.com>
> ---
>  README                     |    1 +
>  arch/arm/cpu/armv7/start.S |    2 +-
>  2 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/README b/README
> index 7cb7c4f..a496c65 100644
> --- a/README
> +++ b/README
> @@ -566,6 +566,7 @@ The following options need to be configured:
>  		CONFIG_ARM_ERRATA_742230
>  		CONFIG_ARM_ERRATA_743622
>  		CONFIG_ARM_ERRATA_751472
> +		CONFIG_ARM_ERRATA_794072
>  
>  		If set, the workarounds for these ARM errata are applied early
>  		during U-Boot startup. Note that these options force the
> diff --git a/arch/arm/cpu/armv7/start.S b/arch/arm/cpu/armv7/start.S
> index ac1e55a..f3830c8 100644
> --- a/arch/arm/cpu/armv7/start.S
> +++ b/arch/arm/cpu/armv7/start.S
> @@ -205,7 +205,7 @@ ENTRY(cpu_init_cp15)
>  	mcr	p15, 0, r0, c1, c0, 0	@ write system control register
>  #endif
>  
> -#ifdef CONFIG_ARM_ERRATA_742230
> +#if (defined(CONFIG_ARM_ERRATA_742230) || defined(CONFIG_ARM_ERRATA_794072))
>  	mrc	p15, 0, r0, c15, c0, 1	@ read diagnostic register
>  	orr	r0, r0, #1 << 4		@ set bit #4
>  	mcr	p15, 0, r0, c15, c0, 1	@ write diagnostic register
> 

Apart having an additional errata number, which is the contribute of
CONFIG_ARM_ERRATA_794072 ? We are already covered with
CONFIG_ARM_ERRATA_742230 and the work-around for dmb is already implemented.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2014-04-02 15:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-02 13:55 [U-Boot] [PATCH v3 0/3] Add workaround for Cortex-A9 errata nitin.garg at freescale.com
2014-04-02 13:55 ` [U-Boot] [PATCH v3 1/3] ARM: Add workaround for Cortex-A9 errata 794072 nitin.garg at freescale.com
2014-04-02 15:26   ` Stefano Babic [this message]
2014-04-02 15:46     ` Nitin Garg
2014-04-07 16:16   ` Stefano Babic
2014-04-02 13:55 ` [U-Boot] [PATCH v3 2/3] ARM: Add workaround for Cortex-A9 errata 761320 nitin.garg at freescale.com
2014-04-02 15:28   ` Stefano Babic
2014-04-02 15:47     ` Nitin Garg
2014-04-03  1:27   ` Fabio Estevam
2014-04-07 16:16   ` Stefano Babic
2014-04-02 13:55 ` [U-Boot] [PATCH v3 3/3] MX6: Enable ARM errata workaround 794072 and 761320 nitin.garg at freescale.com
2014-04-07 16:16   ` Stefano Babic
  -- strict thread matches above, loose matches on Subject: below --
2014-04-02 13:51 [U-Boot] [PATCH v3 0/3] Add workaround for Cortex-A9 errata nitin.garg at freescale.com
2014-04-02 13:51 ` [U-Boot] [PATCH v3 1/3] ARM: Add workaround for Cortex-A9 errata 794072 nitin.garg at freescale.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533C2C15.6030400@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).