* [U-Boot] [PATCH v3 0/3] Add workaround for Cortex-A9 errata
@ 2014-04-02 13:55 nitin.garg at freescale.com
2014-04-02 13:55 ` [U-Boot] [PATCH v3 1/3] ARM: Add workaround for Cortex-A9 errata 794072 nitin.garg at freescale.com
` (2 more replies)
0 siblings, 3 replies; 13+ messages in thread
From: nitin.garg at freescale.com @ 2014-04-02 13:55 UTC (permalink / raw)
To: u-boot
From: Nitin Garg <nitin.garg@freescale.com>
These patches implement workaround for 2 Cortex-A9 erratas.
Enable these errata workaround for MX6.
Changes since v2:
- Added Acked-by Dirk Behme for PATCH 1/3
- Added Stefano for review
Changes since v1:
- Enabled these erratas for MX6 as suggested by Fabio Estevam
- Reused code for errata 794072 as suggested by Dirk Behme
Nitin Garg (3):
ARM: Add workaround for Cortex-A9 errata 794072
ARM: Add workaround for Cortex-A9 errata 761320
MX6: Enable ARM errata workaround 794072 and 761320
README | 2 ++
arch/arm/cpu/armv7/start.S | 7 ++++++-
include/configs/mx6_common.h | 2 ++
3 files changed, 10 insertions(+), 1 deletions(-)
--
1.7.4.1
^ permalink raw reply [flat|nested] 13+ messages in thread* [U-Boot] [PATCH v3 1/3] ARM: Add workaround for Cortex-A9 errata 794072 2014-04-02 13:55 [U-Boot] [PATCH v3 0/3] Add workaround for Cortex-A9 errata nitin.garg at freescale.com @ 2014-04-02 13:55 ` nitin.garg at freescale.com 2014-04-02 15:26 ` Stefano Babic 2014-04-07 16:16 ` Stefano Babic 2014-04-02 13:55 ` [U-Boot] [PATCH v3 2/3] ARM: Add workaround for Cortex-A9 errata 761320 nitin.garg at freescale.com 2014-04-02 13:55 ` [U-Boot] [PATCH v3 3/3] MX6: Enable ARM errata workaround 794072 and 761320 nitin.garg at freescale.com 2 siblings, 2 replies; 13+ messages in thread From: nitin.garg at freescale.com @ 2014-04-02 13:55 UTC (permalink / raw) To: u-boot From: Nitin Garg <nitin.garg@freescale.com> A short loop including a DMB instruction might cause a denial of service on another processor which executes a CP15 broadcast operation. Exists on r1, r2, r3, r4 revisions. Signed-off-by: Nitin Garg <nitin.garg@freescale.com> Acked-by: Dirk Behme <dirk.behme@de.bosch.com> --- README | 1 + arch/arm/cpu/armv7/start.S | 2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/README b/README index 7cb7c4f..a496c65 100644 --- a/README +++ b/README @@ -566,6 +566,7 @@ The following options need to be configured: CONFIG_ARM_ERRATA_742230 CONFIG_ARM_ERRATA_743622 CONFIG_ARM_ERRATA_751472 + CONFIG_ARM_ERRATA_794072 If set, the workarounds for these ARM errata are applied early during U-Boot startup. Note that these options force the diff --git a/arch/arm/cpu/armv7/start.S b/arch/arm/cpu/armv7/start.S index ac1e55a..f3830c8 100644 --- a/arch/arm/cpu/armv7/start.S +++ b/arch/arm/cpu/armv7/start.S @@ -205,7 +205,7 @@ ENTRY(cpu_init_cp15) mcr p15, 0, r0, c1, c0, 0 @ write system control register #endif -#ifdef CONFIG_ARM_ERRATA_742230 +#if (defined(CONFIG_ARM_ERRATA_742230) || defined(CONFIG_ARM_ERRATA_794072)) mrc p15, 0, r0, c15, c0, 1 @ read diagnostic register orr r0, r0, #1 << 4 @ set bit #4 mcr p15, 0, r0, c15, c0, 1 @ write diagnostic register -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v3 1/3] ARM: Add workaround for Cortex-A9 errata 794072 2014-04-02 13:55 ` [U-Boot] [PATCH v3 1/3] ARM: Add workaround for Cortex-A9 errata 794072 nitin.garg at freescale.com @ 2014-04-02 15:26 ` Stefano Babic 2014-04-02 15:46 ` Nitin Garg 2014-04-07 16:16 ` Stefano Babic 1 sibling, 1 reply; 13+ messages in thread From: Stefano Babic @ 2014-04-02 15:26 UTC (permalink / raw) To: u-boot Hi Nitin, On 02/04/2014 15:55, nitin.garg at freescale.com wrote: > From: Nitin Garg <nitin.garg@freescale.com> > > A short loop including a DMB instruction might cause a denial of > service on another processor which executes a CP15 broadcast operation. > Exists on r1, r2, r3, r4 revisions. > > Signed-off-by: Nitin Garg <nitin.garg@freescale.com> > Acked-by: Dirk Behme <dirk.behme@de.bosch.com> > --- > README | 1 + > arch/arm/cpu/armv7/start.S | 2 +- > 2 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/README b/README > index 7cb7c4f..a496c65 100644 > --- a/README > +++ b/README > @@ -566,6 +566,7 @@ The following options need to be configured: > CONFIG_ARM_ERRATA_742230 > CONFIG_ARM_ERRATA_743622 > CONFIG_ARM_ERRATA_751472 > + CONFIG_ARM_ERRATA_794072 > > If set, the workarounds for these ARM errata are applied early > during U-Boot startup. Note that these options force the > diff --git a/arch/arm/cpu/armv7/start.S b/arch/arm/cpu/armv7/start.S > index ac1e55a..f3830c8 100644 > --- a/arch/arm/cpu/armv7/start.S > +++ b/arch/arm/cpu/armv7/start.S > @@ -205,7 +205,7 @@ ENTRY(cpu_init_cp15) > mcr p15, 0, r0, c1, c0, 0 @ write system control register > #endif > > -#ifdef CONFIG_ARM_ERRATA_742230 > +#if (defined(CONFIG_ARM_ERRATA_742230) || defined(CONFIG_ARM_ERRATA_794072)) > mrc p15, 0, r0, c15, c0, 1 @ read diagnostic register > orr r0, r0, #1 << 4 @ set bit #4 > mcr p15, 0, r0, c15, c0, 1 @ write diagnostic register > Apart having an additional errata number, which is the contribute of CONFIG_ARM_ERRATA_794072 ? We are already covered with CONFIG_ARM_ERRATA_742230 and the work-around for dmb is already implemented. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v3 1/3] ARM: Add workaround for Cortex-A9 errata 794072 2014-04-02 15:26 ` Stefano Babic @ 2014-04-02 15:46 ` Nitin Garg 0 siblings, 0 replies; 13+ messages in thread From: Nitin Garg @ 2014-04-02 15:46 UTC (permalink / raw) To: u-boot Hi Stefano, Errata 742230 applies to r1p0, r1p1, r1p2, r1p3, r2p0, r2p1, r2p2 revision of Cortex-A9. Errata 794072 applies to r1, 2, r3, r4 revisions. Software workaround is same for both. Since diff products use diff revisions of core, I would suggest to have it this way. Otherwise it might lead to confusion if one has to enable 742230 (for 794072 workaround) even though the core revision does not need it. Regards, Nitin Garg -----Original Message----- From: Stefano Babic [mailto:sbabic at denx.de] Sent: Wednesday, April 02, 2014 10:26 AM To: Garg Nitin-B37173; trini at ti.com; Estevam Fabio-R49496; sbabic at denx.de Cc: u-boot at lists.denx.de Subject: Re: [PATCH v3 1/3] ARM: Add workaround for Cortex-A9 errata 794072 Hi Nitin, On 02/04/2014 15:55, nitin.garg at freescale.com wrote: > From: Nitin Garg <nitin.garg@freescale.com> > > A short loop including a DMB instruction might cause a denial of > service on another processor which executes a CP15 broadcast operation. > Exists on r1, r2, r3, r4 revisions. > > Signed-off-by: Nitin Garg <nitin.garg@freescale.com> > Acked-by: Dirk Behme <dirk.behme@de.bosch.com> > --- > README | 1 + > arch/arm/cpu/armv7/start.S | 2 +- > 2 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/README b/README > index 7cb7c4f..a496c65 100644 > --- a/README > +++ b/README > @@ -566,6 +566,7 @@ The following options need to be configured: > CONFIG_ARM_ERRATA_742230 > CONFIG_ARM_ERRATA_743622 > CONFIG_ARM_ERRATA_751472 > + CONFIG_ARM_ERRATA_794072 > > If set, the workarounds for these ARM errata are applied early > during U-Boot startup. Note that these options force the diff --git > a/arch/arm/cpu/armv7/start.S b/arch/arm/cpu/armv7/start.S index > ac1e55a..f3830c8 100644 > --- a/arch/arm/cpu/armv7/start.S > +++ b/arch/arm/cpu/armv7/start.S > @@ -205,7 +205,7 @@ ENTRY(cpu_init_cp15) > mcr p15, 0, r0, c1, c0, 0 @ write system control register > #endif > > -#ifdef CONFIG_ARM_ERRATA_742230 > +#if (defined(CONFIG_ARM_ERRATA_742230) || > +defined(CONFIG_ARM_ERRATA_794072)) > mrc p15, 0, r0, c15, c0, 1 @ read diagnostic register > orr r0, r0, #1 << 4 @ set bit #4 > mcr p15, 0, r0, c15, c0, 1 @ write diagnostic register > Apart having an additional errata number, which is the contribute of CONFIG_ARM_ERRATA_794072 ? We are already covered with CONFIG_ARM_ERRATA_742230 and the work-around for dmb is already implemented. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v3 1/3] ARM: Add workaround for Cortex-A9 errata 794072 2014-04-02 13:55 ` [U-Boot] [PATCH v3 1/3] ARM: Add workaround for Cortex-A9 errata 794072 nitin.garg at freescale.com 2014-04-02 15:26 ` Stefano Babic @ 2014-04-07 16:16 ` Stefano Babic 1 sibling, 0 replies; 13+ messages in thread From: Stefano Babic @ 2014-04-07 16:16 UTC (permalink / raw) To: u-boot On 02/04/2014 15:55, nitin.garg at freescale.com wrote: > From: Nitin Garg <nitin.garg@freescale.com> > > A short loop including a DMB instruction might cause a denial of > service on another processor which executes a CP15 broadcast operation. > Exists on r1, r2, r3, r4 revisions. > > Signed-off-by: Nitin Garg <nitin.garg@freescale.com> > Acked-by: Dirk Behme <dirk.behme@de.bosch.com> > --- Applied to u-boot-imx, thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v3 2/3] ARM: Add workaround for Cortex-A9 errata 761320 2014-04-02 13:55 [U-Boot] [PATCH v3 0/3] Add workaround for Cortex-A9 errata nitin.garg at freescale.com 2014-04-02 13:55 ` [U-Boot] [PATCH v3 1/3] ARM: Add workaround for Cortex-A9 errata 794072 nitin.garg at freescale.com @ 2014-04-02 13:55 ` nitin.garg at freescale.com 2014-04-02 15:28 ` Stefano Babic ` (2 more replies) 2014-04-02 13:55 ` [U-Boot] [PATCH v3 3/3] MX6: Enable ARM errata workaround 794072 and 761320 nitin.garg at freescale.com 2 siblings, 3 replies; 13+ messages in thread From: nitin.garg at freescale.com @ 2014-04-02 13:55 UTC (permalink / raw) To: u-boot From: Nitin Garg <nitin.garg@freescale.com> Full cache line writes to the same memory region from at least two processors might deadlock the processor. Exists on r1, r2, r3 revisions. Signed-off-by: Nitin Garg <nitin.garg@freescale.com> --- README | 1 + arch/arm/cpu/armv7/start.S | 5 +++++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/README b/README index a496c65..b7c0f68 100644 --- a/README +++ b/README @@ -567,6 +567,7 @@ The following options need to be configured: CONFIG_ARM_ERRATA_743622 CONFIG_ARM_ERRATA_751472 CONFIG_ARM_ERRATA_794072 + CONFIG_ARM_ERRATA_761320 If set, the workarounds for these ARM errata are applied early during U-Boot startup. Note that these options force the diff --git a/arch/arm/cpu/armv7/start.S b/arch/arm/cpu/armv7/start.S index f3830c8..27be451 100644 --- a/arch/arm/cpu/armv7/start.S +++ b/arch/arm/cpu/armv7/start.S @@ -222,6 +222,11 @@ ENTRY(cpu_init_cp15) orr r0, r0, #1 << 11 @ set bit #11 mcr p15, 0, r0, c15, c0, 1 @ write diagnostic register #endif +#ifdef CONFIG_ARM_ERRATA_761320 + mrc p15, 0, r0, c15, c0, 1 @ read diagnostic register + orr r0, r0, #1 << 21 @ set bit #21 + mcr p15, 0, r0, c15, c0, 1 @ write diagnostic register +#endif mov pc, lr @ back to my caller ENDPROC(cpu_init_cp15) -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v3 2/3] ARM: Add workaround for Cortex-A9 errata 761320 2014-04-02 13:55 ` [U-Boot] [PATCH v3 2/3] ARM: Add workaround for Cortex-A9 errata 761320 nitin.garg at freescale.com @ 2014-04-02 15:28 ` Stefano Babic 2014-04-02 15:47 ` Nitin Garg 2014-04-03 1:27 ` Fabio Estevam 2014-04-07 16:16 ` Stefano Babic 2 siblings, 1 reply; 13+ messages in thread From: Stefano Babic @ 2014-04-02 15:28 UTC (permalink / raw) To: u-boot Hi Nitin, On 02/04/2014 15:55, nitin.garg at freescale.com wrote: > From: Nitin Garg <nitin.garg@freescale.com> > > Full cache line writes to the same memory region from at least two > processors might deadlock the processor. Exists on r1, r2, r3 > revisions. > > Signed-off-by: Nitin Garg <nitin.garg@freescale.com> > --- > README | 1 + > arch/arm/cpu/armv7/start.S | 5 +++++ > 2 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/README b/README > index a496c65..b7c0f68 100644 > --- a/README > +++ b/README > @@ -567,6 +567,7 @@ The following options need to be configured: > CONFIG_ARM_ERRATA_743622 > CONFIG_ARM_ERRATA_751472 > CONFIG_ARM_ERRATA_794072 > + CONFIG_ARM_ERRATA_761320 > > If set, the workarounds for these ARM errata are applied early > during U-Boot startup. Note that these options force the > diff --git a/arch/arm/cpu/armv7/start.S b/arch/arm/cpu/armv7/start.S > index f3830c8..27be451 100644 > --- a/arch/arm/cpu/armv7/start.S > +++ b/arch/arm/cpu/armv7/start.S > @@ -222,6 +222,11 @@ ENTRY(cpu_init_cp15) > orr r0, r0, #1 << 11 @ set bit #11 > mcr p15, 0, r0, c15, c0, 1 @ write diagnostic register > #endif > +#ifdef CONFIG_ARM_ERRATA_761320 > + mrc p15, 0, r0, c15, c0, 1 @ read diagnostic register > + orr r0, r0, #1 << 21 @ set bit #21 > + mcr p15, 0, r0, c15, c0, 1 @ write diagnostic register > +#endif > > mov pc, lr @ back to my caller > ENDPROC(cpu_init_cp15) > I admit I am not able to find the documentation for this errata neither the ARM center nor in the i.MX6 errata. Do you have a link to get some more infos about it ? Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v3 2/3] ARM: Add workaround for Cortex-A9 errata 761320 2014-04-02 15:28 ` Stefano Babic @ 2014-04-02 15:47 ` Nitin Garg 0 siblings, 0 replies; 13+ messages in thread From: Nitin Garg @ 2014-04-02 15:47 UTC (permalink / raw) To: u-boot Sorry, I don't have a link. We are in the process of updating the i.MX6 Chip errata document to include this. Regards, Nitin Garg -----Original Message----- From: Stefano Babic [mailto:sbabic at denx.de] Sent: Wednesday, April 02, 2014 10:29 AM To: Garg Nitin-B37173; trini at ti.com; Estevam Fabio-R49496; sbabic at denx.de Cc: u-boot at lists.denx.de Subject: Re: [PATCH v3 2/3] ARM: Add workaround for Cortex-A9 errata 761320 Hi Nitin, On 02/04/2014 15:55, nitin.garg at freescale.com wrote: > From: Nitin Garg <nitin.garg@freescale.com> > > Full cache line writes to the same memory region from at least two > processors might deadlock the processor. Exists on r1, r2, r3 > revisions. > > Signed-off-by: Nitin Garg <nitin.garg@freescale.com> > --- > README | 1 + > arch/arm/cpu/armv7/start.S | 5 +++++ > 2 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/README b/README > index a496c65..b7c0f68 100644 > --- a/README > +++ b/README > @@ -567,6 +567,7 @@ The following options need to be configured: > CONFIG_ARM_ERRATA_743622 > CONFIG_ARM_ERRATA_751472 > CONFIG_ARM_ERRATA_794072 > + CONFIG_ARM_ERRATA_761320 > > If set, the workarounds for these ARM errata are applied early > during U-Boot startup. Note that these options force the diff --git > a/arch/arm/cpu/armv7/start.S b/arch/arm/cpu/armv7/start.S index > f3830c8..27be451 100644 > --- a/arch/arm/cpu/armv7/start.S > +++ b/arch/arm/cpu/armv7/start.S > @@ -222,6 +222,11 @@ ENTRY(cpu_init_cp15) > orr r0, r0, #1 << 11 @ set bit #11 > mcr p15, 0, r0, c15, c0, 1 @ write diagnostic register > #endif > +#ifdef CONFIG_ARM_ERRATA_761320 > + mrc p15, 0, r0, c15, c0, 1 @ read diagnostic register > + orr r0, r0, #1 << 21 @ set bit #21 > + mcr p15, 0, r0, c15, c0, 1 @ write diagnostic register > +#endif > > mov pc, lr @ back to my caller > ENDPROC(cpu_init_cp15) > I admit I am not able to find the documentation for this errata neither the ARM center nor in the i.MX6 errata. Do you have a link to get some more infos about it ? Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v3 2/3] ARM: Add workaround for Cortex-A9 errata 761320 2014-04-02 13:55 ` [U-Boot] [PATCH v3 2/3] ARM: Add workaround for Cortex-A9 errata 761320 nitin.garg at freescale.com 2014-04-02 15:28 ` Stefano Babic @ 2014-04-03 1:27 ` Fabio Estevam 2014-04-07 16:16 ` Stefano Babic 2 siblings, 0 replies; 13+ messages in thread From: Fabio Estevam @ 2014-04-03 1:27 UTC (permalink / raw) To: u-boot On Wed, Apr 2, 2014 at 10:55 AM, <nitin.garg@freescale.com> wrote: > From: Nitin Garg <nitin.garg@freescale.com> > > Full cache line writes to the same memory region from at least two > processors might deadlock the processor. Exists on r1, r2, r3 > revisions. > > Signed-off-by: Nitin Garg <nitin.garg@freescale.com> Acked-by: Fabio Estevam <fabio.estevam@freescale.com> ^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v3 2/3] ARM: Add workaround for Cortex-A9 errata 761320 2014-04-02 13:55 ` [U-Boot] [PATCH v3 2/3] ARM: Add workaround for Cortex-A9 errata 761320 nitin.garg at freescale.com 2014-04-02 15:28 ` Stefano Babic 2014-04-03 1:27 ` Fabio Estevam @ 2014-04-07 16:16 ` Stefano Babic 2 siblings, 0 replies; 13+ messages in thread From: Stefano Babic @ 2014-04-07 16:16 UTC (permalink / raw) To: u-boot On 02/04/2014 15:55, nitin.garg at freescale.com wrote: > From: Nitin Garg <nitin.garg@freescale.com> > > Full cache line writes to the same memory region from at least two > processors might deadlock the processor. Exists on r1, r2, r3 > revisions. > > Signed-off-by: Nitin Garg <nitin.garg@freescale.com> > --- Applied to u-boot-imx, thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v3 3/3] MX6: Enable ARM errata workaround 794072 and 761320 2014-04-02 13:55 [U-Boot] [PATCH v3 0/3] Add workaround for Cortex-A9 errata nitin.garg at freescale.com 2014-04-02 13:55 ` [U-Boot] [PATCH v3 1/3] ARM: Add workaround for Cortex-A9 errata 794072 nitin.garg at freescale.com 2014-04-02 13:55 ` [U-Boot] [PATCH v3 2/3] ARM: Add workaround for Cortex-A9 errata 761320 nitin.garg at freescale.com @ 2014-04-02 13:55 ` nitin.garg at freescale.com 2014-04-07 16:16 ` Stefano Babic 2 siblings, 1 reply; 13+ messages in thread From: nitin.garg at freescale.com @ 2014-04-02 13:55 UTC (permalink / raw) To: u-boot From: Nitin Garg <nitin.garg@freescale.com> Since MX6 is Cortex-A9 r2p10, enable software workaround for errata 794072 and 761320. Signed-off-by: Nitin Garg <nitin.garg@freescale.com> --- include/configs/mx6_common.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/configs/mx6_common.h b/include/configs/mx6_common.h index eb107d3..8a8920f 100644 --- a/include/configs/mx6_common.h +++ b/include/configs/mx6_common.h @@ -20,6 +20,8 @@ #define CONFIG_ARM_ERRATA_742230 #define CONFIG_ARM_ERRATA_743622 #define CONFIG_ARM_ERRATA_751472 +#define CONFIG_ARM_ERRATA_794072 +#define CONFIG_ARM_ERRATA_761320 #define CONFIG_BOARD_POSTCLK_INIT #ifndef CONFIG_SYS_L2CACHE_OFF -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v3 3/3] MX6: Enable ARM errata workaround 794072 and 761320 2014-04-02 13:55 ` [U-Boot] [PATCH v3 3/3] MX6: Enable ARM errata workaround 794072 and 761320 nitin.garg at freescale.com @ 2014-04-07 16:16 ` Stefano Babic 0 siblings, 0 replies; 13+ messages in thread From: Stefano Babic @ 2014-04-07 16:16 UTC (permalink / raw) To: u-boot On 02/04/2014 15:55, nitin.garg at freescale.com wrote: > From: Nitin Garg <nitin.garg@freescale.com> > > Since MX6 is Cortex-A9 r2p10, enable software workaround > for errata 794072 and 761320. > > Signed-off-by: Nitin Garg <nitin.garg@freescale.com> > --- Applied to u-boot-imx, thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v3 0/3] Add workaround for Cortex-A9 errata @ 2014-04-02 13:51 nitin.garg at freescale.com 2014-04-02 13:51 ` [U-Boot] [PATCH v3 2/3] ARM: Add workaround for Cortex-A9 errata 761320 nitin.garg at freescale.com 0 siblings, 1 reply; 13+ messages in thread From: nitin.garg at freescale.com @ 2014-04-02 13:51 UTC (permalink / raw) To: u-boot From: Nitin Garg <nitin.garg@freescale.com> These patches implement workaround for 2 Cortex-A9 erratas. Enable these errata workaround for MX6. Changes since v2: - Added Acked-by Dirk Behme for PATCH 1/3 - Added Stefano for review Changes since v1: - Enabled these erratas for MX6 as suggested by Fabio Estevam - Reused code for errata 794072 as suggested by Dirk Behme Nitin Garg (3): ARM: Add workaround for Cortex-A9 errata 794072 ARM: Add workaround for Cortex-A9 errata 761320 MX6: Enable ARM errata workaround 794072 and 761320 README | 2 ++ arch/arm/cpu/armv7/start.S | 7 ++++++- include/configs/mx6_common.h | 2 ++ 3 files changed, 10 insertions(+), 1 deletions(-) -- 1.7.4.1 ^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH v3 2/3] ARM: Add workaround for Cortex-A9 errata 761320 2014-04-02 13:51 [U-Boot] [PATCH v3 0/3] Add workaround for Cortex-A9 errata nitin.garg at freescale.com @ 2014-04-02 13:51 ` nitin.garg at freescale.com 0 siblings, 0 replies; 13+ messages in thread From: nitin.garg at freescale.com @ 2014-04-02 13:51 UTC (permalink / raw) To: u-boot From: Nitin Garg <nitin.garg@freescale.com> Full cache line writes to the same memory region from at least two processors might deadlock the processor. Exists on r1, r2, r3 revisions. Signed-off-by: Nitin Garg <nitin.garg@freescale.com> --- README | 1 + arch/arm/cpu/armv7/start.S | 5 +++++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/README b/README index a496c65..b7c0f68 100644 --- a/README +++ b/README @@ -567,6 +567,7 @@ The following options need to be configured: CONFIG_ARM_ERRATA_743622 CONFIG_ARM_ERRATA_751472 CONFIG_ARM_ERRATA_794072 + CONFIG_ARM_ERRATA_761320 If set, the workarounds for these ARM errata are applied early during U-Boot startup. Note that these options force the diff --git a/arch/arm/cpu/armv7/start.S b/arch/arm/cpu/armv7/start.S index f3830c8..27be451 100644 --- a/arch/arm/cpu/armv7/start.S +++ b/arch/arm/cpu/armv7/start.S @@ -222,6 +222,11 @@ ENTRY(cpu_init_cp15) orr r0, r0, #1 << 11 @ set bit #11 mcr p15, 0, r0, c15, c0, 1 @ write diagnostic register #endif +#ifdef CONFIG_ARM_ERRATA_761320 + mrc p15, 0, r0, c15, c0, 1 @ read diagnostic register + orr r0, r0, #1 << 21 @ set bit #21 + mcr p15, 0, r0, c15, c0, 1 @ write diagnostic register +#endif mov pc, lr @ back to my caller ENDPROC(cpu_init_cp15) -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
end of thread, other threads:[~2014-04-07 16:16 UTC | newest] Thread overview: 13+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-04-02 13:55 [U-Boot] [PATCH v3 0/3] Add workaround for Cortex-A9 errata nitin.garg at freescale.com 2014-04-02 13:55 ` [U-Boot] [PATCH v3 1/3] ARM: Add workaround for Cortex-A9 errata 794072 nitin.garg at freescale.com 2014-04-02 15:26 ` Stefano Babic 2014-04-02 15:46 ` Nitin Garg 2014-04-07 16:16 ` Stefano Babic 2014-04-02 13:55 ` [U-Boot] [PATCH v3 2/3] ARM: Add workaround for Cortex-A9 errata 761320 nitin.garg at freescale.com 2014-04-02 15:28 ` Stefano Babic 2014-04-02 15:47 ` Nitin Garg 2014-04-03 1:27 ` Fabio Estevam 2014-04-07 16:16 ` Stefano Babic 2014-04-02 13:55 ` [U-Boot] [PATCH v3 3/3] MX6: Enable ARM errata workaround 794072 and 761320 nitin.garg at freescale.com 2014-04-07 16:16 ` Stefano Babic -- strict thread matches above, loose matches on Subject: below -- 2014-04-02 13:51 [U-Boot] [PATCH v3 0/3] Add workaround for Cortex-A9 errata nitin.garg at freescale.com 2014-04-02 13:51 ` [U-Boot] [PATCH v3 2/3] ARM: Add workaround for Cortex-A9 errata 761320 nitin.garg at freescale.com
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).