[U-Boot] Bug in buildsystem for SPL LDSCRIPT

[U-Boot] Bug in buildsystem for SPL LDSCRIPT

[Andreas Bießmann]

and also to the list ... sorry for the noise

On 04/07/2014 11:27 AM, Andreas Bie?mann wrote:
> Hi Masahiro,
> 
> a late bug report ;) changing my board config file will not regenerate
> the spl/u-boot-spl.lds for the board though it depends on it. The
> LDSCRIPT is patched with some size information for range checking which
> is not updated in my case. However regenerating the file by deleting it
> first works. Cold you please provide a fix for that in 2014.04?
> 
> Best regards
> 
> Andreas Bie?mann
> 

[U-Boot] Bug in buildsystem for SPL LDSCRIPT

[Masahiro Yamada]

Hi Andreas,


On Mon, 07 Apr 2014 11:35:07 +0200
"Andreas Biesmann" <andreas.devel@googlemail.com> wrote:

> and also to the list ... sorry for the noise
> 
> On 04/07/2014 11:27 AM, Andreas Biesmann wrote:
> > Hi Masahiro,
> > 
> > a late bug report ;) changing my board config file will not regenerate
> > the spl/u-boot-spl.lds for the board though it depends on it. The
> > LDSCRIPT is patched with some size information for range checking which
> > is not updated in my case. However regenerating the file by deleting it
> > first works. Cold you please provide a fix for that in 2014.04?

Could you give me an example in which spl/u-bool-spl.lds is not
correctly regenerated.

Which board did you build first and which one did you do next?


Best Regards
Masahiro Yamada

[U-Boot] Bug in buildsystem for SPL LDSCRIPT

[Andreas Bießmann]

Hi Masahiro,

On 04/09/2014 04:27 AM, Masahiro Yamada wrote:
> On Mon, 07 Apr 2014 11:35:07 +0200
> "Andreas Biesmann" <andreas.devel@googlemail.com> wrote:
> 
>> and also to the list ... sorry for the noise
>>
>> On 04/07/2014 11:27 AM, Andreas Biesmann wrote:
>>> Hi Masahiro,
>>>
>>> a late bug report ;) changing my board config file will not regenerate
>>> the spl/u-boot-spl.lds for the board though it depends on it. The
>>> LDSCRIPT is patched with some size information for range checking which
>>> is not updated in my case. However regenerating the file by deleting it
>>> first works. Cold you please provide a fix for that in 2014.04?
> 
> Could you give me an example in which spl/u-bool-spl.lds is not
> correctly regenerated.


it is not regenerated when the configuration is changed. Here is my use
case:

---8<---
abiessmann at punisher % git describe
v2014.04-rc3-91-g36490ee
abiessmann at punisher % PATH=$ARMa8_PATH:$PATH make O=/tmp/tricorder
ARCH=arm CROSS_COMPILE=arm-cortexa8-linux-gnueabi- -j16 -s
tricorder_config all
Configuring for tricorder board...
PATH=$ARMa8_PATH:$PATH make O=/tmp/tricorder ARCH=arm  -j16 -s  all
27.23s user 2.47s system 539% cpu 5.507 total
abiessmann at punisher % grep CONFIG_SPL_MAX_SIZE include/configs/tricorder.h
#define CONFIG_SPL_MAX_SIZE		(57 * 1024)	/* 7 KB for stack */
abiessmann@punisher % head -1 /tmp/tricorder/spl/u-boot-spl.lds
MEMORY { .sram : ORIGIN = 0x40200000, LENGTH = (57 * 1024) }
--->8---


... modify configuration

---8<---
abiessmann at punisher % grep CONFIG_SPL_MAX_SIZE include/configs/tricorder.h
#define CONFIG_SPL_MAX_SIZE		(59 * 1024)	/* 7 KB for stack */
abiessmann at punisher % PATH=$ARMa8_PATH:$PATH make O=/tmp/tricorder
ARCH=arm CROSS_COMPILE=arm-cortexa8-linux-gnueabi- -j16 -s all
PATH=$ARMa8_PATH:$PATH make O=/tmp/tricorder ARCH=arm  -j16 -s all
25.25s user 2.16s system 550% cpu 4.974 total
abiessmann at punisher % head -1 /tmp/tricorder/spl/u-boot-spl.lds
MEMORY { .sram : ORIGIN = 0x40200000, LENGTH = (57 * 1024) }
abiessmann at punisher % ls -l /tmp/tricorder/spl/u-boot-spl.lds
-rw-r--r-- 1 abiessmann abiessmann 699 Apr  9 08:27
/tmp/tricorder/spl/u-boot-spl.lds
abiessmann at punisher % ls -l /tmp/tricorder/spl/u-boot-spl
-rwxr-xr-x 1 abiessmann abiessmann 571948 Apr  9 08:28
/tmp/tricorder/spl/u-boot-spl*
abiessmann at punisher % ls -l include/configs/tricorder.h
-rw-r--r-- 1 abiessmann abiessmann 12071 Apr  9 08:28
include/configs/tricorder.h
abiessmann@punisher %
--->8---

Best regards

Andreas Bie?mann

[U-Boot] Bug in buildsystem for SPL LDSCRIPT

[Masahiro Yamada]

Hi Andreas,


On Wed, 09 Apr 2014 08:31:53 +0200
"Andreas Biesmann" <andreas.devel@googlemail.com> wrote:

> Hi Masahiro,
> 
> On 04/09/2014 04:27 AM, Masahiro Yamada wrote:
> > On Mon, 07 Apr 2014 11:35:07 +0200
> > "Andreas Biesmann" <andreas.devel@googlemail.com> wrote:
> > 
> >> and also to the list ... sorry for the noise
> >>
> >> On 04/07/2014 11:27 AM, Andreas Biesmann wrote:
> >>> Hi Masahiro,
> >>>
> >>> a late bug report ;) changing my board config file will not regenerate
> >>> the spl/u-boot-spl.lds for the board though it depends on it. The
> >>> LDSCRIPT is patched with some size information for range checking which
> >>> is not updated in my case. However regenerating the file by deleting it
> >>> first works. Cold you please provide a fix for that in 2014.04?


Thanks your bug report!

I think
http://patchwork.ozlabs.org/patch/337822/
should fix the problem.


Best Regards
Masahiro Yamada

[U-Boot] Bug in buildsystem for SPL LDSCRIPT

[Andreas Bießmann]

Hi Masahiro,

On 04/09/2014 01:13 PM, Masahiro Yamada wrote:
> On Wed, 09 Apr 2014 08:31:53 +0200
> "Andreas Biesmann" <andreas.devel@googlemail.com> wrote:
>> On 04/09/2014 04:27 AM, Masahiro Yamada wrote:
>>> On Mon, 07 Apr 2014 11:35:07 +0200
>>> "Andreas Biesmann" <andreas.devel@googlemail.com> wrote:
>>>
>>>> and also to the list ... sorry for the noise
>>>>
>>>> On 04/07/2014 11:27 AM, Andreas Biesmann wrote:
>>>>> Hi Masahiro,
>>>>>
>>>>> a late bug report ;) changing my board config file will not regenerate
>>>>> the spl/u-boot-spl.lds for the board though it depends on it. The
>>>>> LDSCRIPT is patched with some size information for range checking which
>>>>> is not updated in my case. However regenerating the file by deleting it
>>>>> first works. Cold you please provide a fix for that in 2014.04?
> 
> 
> Thanks your bug report!
> 
> I think
> http://patchwork.ozlabs.org/patch/337822/
> should fix the problem.

works like a charm, many thanks!

Best regrads

Andreas Bie?mann