public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] arm:board:trats2:FIX: Clear INFORM4 and INFORM5 registers at correct boot
Date: Thu, 10 Apr 2014 10:09:06 +0900	[thread overview]
Message-ID: <5345EF32.1010102@samsung.com> (raw)
In-Reply-To: <1397048984-22978-1-git-send-email-l.majewski@samsung.com>

On 09/04/14 22:09, Lukasz Majewski wrote:
> During switch to device tree, commit 1ecab0f has removed this code.
> 
> INFORM4 and INFORM5 registers are used by TRATS2 first stage bootloader for
> providing recovery. For normal operation, those two must be cleared out.
> 
> This error emerges when one force reset from u-boot's command line for
> three times.
> 
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> 
> ---
> Changes for v2:
> - Remove redundant cast
> ---
>  board/samsung/trats2/trats2.c |   13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/board/samsung/trats2/trats2.c b/board/samsung/trats2/trats2.c
> index 2a6c9f9..f558ef9 100644
> --- a/board/samsung/trats2/trats2.c
> +++ b/board/samsung/trats2/trats2.c
> @@ -150,9 +150,22 @@ static int pmic_init_max77686(void);
>  
>  int exynos_init(void)
>  {
> +	struct exynos4_power *pwr =
> +		(struct exynos4_power *)samsung_get_base_power();
> +
>  	check_hw_revision();
>  	printf("HW Revision:\t0x%04x\n", board_rev);
>  
> +	/*
> +	 * First bootloader on the TRATS2 platform uses
> +	 * INFORM4 and INFORM5 registers for recovery
> +	 *
> +	 * To indicate correct boot chain - those two
> +	 * registers must be cleared out
> +	 */
> +	writel(0, &pwr->inform4);
> +	writel(0, &pwr->inform5);
> +
>  	return 0;
>  }
>  
> 

Acked-by: Minkyu Kang <mk7.kang@samsung.com>

Thanks,
Minkyu Kang.

  reply	other threads:[~2014-04-10  1:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-09 12:41 [U-Boot] [PATCH] arm:board:trats2:FIX: Clear INFORM4 and INFORM5 registers at correct boot Lukasz Majewski
2014-04-09 12:59 ` Minkyu Kang
2014-04-09 13:02   ` Lukasz Majewski
2014-04-09 13:09 ` [U-Boot] [PATCH v2] " Lukasz Majewski
2014-04-10  1:09   ` Minkyu Kang [this message]
2014-04-11 20:43   ` [U-Boot] [U-Boot, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5345EF32.1010102@samsung.com \
    --to=mk7.kang@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox