[U-Boot] [PATCH v3 4/5] usb/gadget: add the fastboot gadget

Rob Herring
2014-04-15T16:01:08Z

On Tue, Apr 15, 2014 at 10:41 AM, Lukasz Majewski
<l.majewski@samsung.com> wrote:
> Hi Rob,
>
>> From: Sebastian Siewior <bigeasy@linutronix.de>
>>
>> This patch contains an implementation of the fastboot protocol on the
>> device side and a little of documentation.
>> The gadget expects the new-style gadget framework.
>> The gadget implements the getvar, reboot, download and reboot
>> commands. What is missing is the flash handling i.e. writting the
>> image to media.
>>
>> v3 (Rob Herring):
>> This is based on http://patchwork.ozlabs.org/patch/126798/ with the
>> following changes:
>> - Rebase to current mainline and updates for current gadget API
>> - Use SPDX identifiers for licenses
>> - Traced the history and added missing copyright to cmd_fastboot.c
>> - Use load_addr/load_size for transfer buffer
>> - Allow vendor strings to be optional

[snip]

> To sum up:
>
> It seems that you are using UDC driver + gadget approach for fastboot.
>
> However, current gadgets for downloading data (DFU, UMS, THOR) use UDC +
> composite gadget + function.
>
> Also they use common download code - g_dnl.c to implement their
> commands.
>
> I would be more than happy if you were willing to port the fastboot
> protocol to the existing framework.
> For overall picture of the current design please look into the following
> keynote:
> http://www.denx.de/wiki/pub/U-Boot/MiniSummitELCE2013/dfu_elce_u-boot.pdf
>
> Please let me know if you have any questions.

Thanks for your review. I have this working using the common g_dnl.c
code now. I have a bit more clean-up to do and I will post it. My
current branch is here:

git://git.linaro.org/people/rob.herring/u-boot.git fastboot-v2

Rob