From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mateusz Zalega Date: Fri, 11 Apr 2014 13:43:47 +0200 Subject: [U-Boot] [PATCH v3 06/13] USB: gadget: added a saner gadget downloader registration API In-Reply-To: <201404031052.17157.marex@denx.de> References: <1389277919-15279-1-git-send-email-m.zalega@samsung.com> <201404030028.31582.marex@denx.de> <20140403094622.518f6691@amdc2363> <201404031052.17157.marex@denx.de> Message-ID: <5347D573.1050105@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/03/14 10:52, Marek Vasut wrote: >>>> Acked-by: Lukasz Majewski >>> >>> I suggest this goes for -next. Do you agree? >> >> I'm fine with this code going to -next. Thanks in advance. > > Hm, actually, I see we have open issues with the 04/13 V2 patch (why don't you > have default __weak usb_cable_detection() implementation instead of another > #ifdef ?). Existing code relied on boolean value returned from usb_cable_connected(), but there was no way to signal that it's impossible to tell whether cable is connected or not. If you prefer an enum with USBCNT_DONTKNOW as a return value, make a decision. > The whole patchset is a mix of completely unrelated things which should go > through different trees. Can the patchset be reordered/split in some reasonable > chunks ? There are fixes which should go in immediatelly and then features which > should go in for -next. Not exactly unrelated, most of it should be applied in this particular order. It would be less chaotic had it been accepted in one piece. > btw. please keep custodians on CC of the respective patches. OK Regards, -- Mateusz Zalega Samsung R&D Institute Poland