From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuyuki Kobayashi Date: Mon, 14 Apr 2014 15:49:54 +0900 Subject: [U-Boot] [PATCH v2 1/2] i2c: sh_i2c: bugfix: i2c probe command does not work In-Reply-To: References: <1397450710-22144-1-git-send-email-koba@kmckk.co.jp> <1397450710-22144-2-git-send-email-koba@kmckk.co.jp> <534B7079.2030105@denx.de> Message-ID: <534B8512.70800@kmckk.co.jp> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello, Nobihiro, Heiko I found bug in this patch. When I change read length 0 to 1, I have to change buffer address NULL to some valid memory address. I am going to v3 patch as soon as possible. (2014/04/14 15:09), Nobuhiro Iwamatsu wrote: > Hi, > > 2014-04-14 14:22 GMT+09:00 Heiko Schocher : >> Hello Tetsuyuki >> >> Am 14.04.2014 06:45, schrieb Tetsuyuki Kobayashi: >> >>> This is regression of commit 2035d77d i2c: sh_i2c: Update to new >>> CONFIG_SYS_I2C framework >>> >>> Before commit 2035d77d, i2c probe command works properly on kzm9g board. >>> >>> KZM-A9-GT# i2c probe >>> Valid chip addresses: 0C 12 1D 32 39 3D 40 60 >>> >>> After commit 2035d77d, i2c probe command does not work. >>> >>> KZM-A9-GT# i2c probe >>> Valid chip addresses: 00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F 10 >>> 11 12 13 14 15 16 17 18 19 1A 1B 1C 1D 1E 1F 20 21 22 23 24 25 26 27 28 29 >>> 2A 2B 2C 2D 2E 2F 30 31 32 33 34 35 36 37 38 39 3A 3B 3C 3D 3E 3F 40 41 42 >>> 43 44 45 46 47 48 49 4A 4B 4C 4D 4E 4F 50 51 52 53 54 55 56 57 58 59 5A 5B >>> 5C 5D 5E 5F 60 61 62 63 64 65 66 67 68 69 6A 6B 6C 6D 6E 6F 70 71 72 73 74 >>> 75 76 77 78 79 7A 7B 7C 7D 7E 7F >>> >>> sh_i2c_probe() calls sh_i2c_read(), but read length is 0. So acutally it >>> does not read device at all. This patch changes read length to 1. >>> >>> Signed-off-by: Tetsuyuki Kobayashi >>> --- >>> drivers/i2c/sh_i2c.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> I could not find your patch in patchwork ... so I think >> it go through u-boot-sh.git, so: >> >> Acked-by: Heiko Schocher >> > > Thanks! > I think the reason that is not registered in the patchwork, the > subject is because he is 0/2. > Tetsuyuki, could you re-send this patch? > >> Thanks! >> >> bye, >> Heiko >> -- >> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel >> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > > Best regards, > Nobuhiro >