[U-Boot] [PATCH 06/11] MX6: add struct for sharing data between SPL and uboot

Nikita Kiryanov
2014-04-09T14:55:45Z

Hi Tim,

On 04/03/2014 09:01 AM, Tim Harvey wrote:
> This can be used to pass info between the SPL and u-boot.
>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
> arch/arm/include/asm/arch-mx6/sys_proto.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/include/asm/arch-mx6/sys_proto.h b/arch/arm/include/asm/arch-mx6/sys_proto.h
> index 38851a1..f43e09c 100644
> --- a/arch/arm/include/asm/arch-mx6/sys_proto.h
> +++ b/arch/arm/include/asm/arch-mx6/sys_proto.h
> @@ -39,4 +39,9 @@ int mxs_wait_mask_set(struct mxs_register_32 *reg,
> int mxs_wait_mask_clr(struct mxs_register_32 *reg,
> uint32_t mask,
> unsigned int timeout);
> +
> +struct mx6_spl_data {
> + uint8_t boot_mode_idx;
> + uint32_t mem_dram_size;
> +};
> #endif
>

While I'm in favor of having some way for SPL to pass data to U-Boot,
I don't think this patch achieves this as long as we don't have a
common mechanism that makes use of this struct. At the very least I
would've expected to see a #define that is shared by SPL and U-Boot
that defines the address for this struct (if we were to use the ventana
implementation).

--
Regards,
Nikita.