From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Mon, 14 Apr 2014 14:35:27 +0200 Subject: [U-Boot] [PATCH 06/11] MX6: add struct for sharing data between SPL and uboot In-Reply-To: <1396504871-1454-7-git-send-email-tharvey@gateworks.com> References: <1396504871-1454-1-git-send-email-tharvey@gateworks.com> <1396504871-1454-7-git-send-email-tharvey@gateworks.com> Message-ID: <534BD60F.3030504@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tim, On 03/04/2014 08:01, Tim Harvey wrote: > This can be used to pass info between the SPL and u-boot. > > Signed-off-by: Tim Harvey > --- > arch/arm/include/asm/arch-mx6/sys_proto.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/include/asm/arch-mx6/sys_proto.h b/arch/arm/include/asm/arch-mx6/sys_proto.h > index 38851a1..f43e09c 100644 > --- a/arch/arm/include/asm/arch-mx6/sys_proto.h > +++ b/arch/arm/include/asm/arch-mx6/sys_proto.h > @@ -39,4 +39,9 @@ int mxs_wait_mask_set(struct mxs_register_32 *reg, > int mxs_wait_mask_clr(struct mxs_register_32 *reg, > uint32_t mask, > unsigned int timeout); > + > +struct mx6_spl_data { > + uint8_t boot_mode_idx; > + uint32_t mem_dram_size; > +}; > #endif I see checking your patch that the MXS uses the same concept. And as far as I can see, boot_mode_idx is used only to print the boot devioce However, we have not generally a concept to pass data between SPL and u-boot. My question is even if it is really needed. The size of DRAM is retrived at run time by u-boot running get_ram_size(), that is a better solution. SPL is thought to generally load an image (of course, in most cases it is u-boot). In Falcon mode, the kernel is started without running u-boot, making this structure useless. Do we really need such a way (but then, it must be generalized as SPL API), or can we get rid of it ? Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================