From mboxrd@z Thu Jan 1 00:00:00 1970 From: York Sun Date: Wed, 16 Apr 2014 18:42:06 -0700 Subject: [U-Boot] [PATCH v7 3/3] T1040QDS/U-QE: Add u-qe support to t1040qds In-Reply-To: References: <1395390106-20439-1-git-send-email-B45475@freescale.com> <1395390106-20439-3-git-send-email-B45475@freescale.com> <533332BA.6040206@freescale.com> <534F0C1C.6040301@freescale.com> Message-ID: <534F316E.4020607@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/16/2014 06:39 PM, Zhao Qiang-B45475 wrote: > On 04/17/2014 07:03 PM, York Sun wrote: > >> -----Original Message----- >> From: Sun York-R58495 >> Sent: Thursday, April 17, 2014 7:03 AM >> To: Zhao Qiang-B45475; u-boot at lists.denx.de >> Cc: Xie Xiaobo-R63061 >> Subject: Re: [U-Boot] [PATCH v7 3/3] T1040QDS/U-QE: Add u-qe support to >> t1040qds >> >> On 03/26/2014 01:04 PM, York Sun wrote: >>> On 03/21/2014 01:21 AM, Zhao Qiang wrote: >>>> >>>> +static void qe_board_setup(void) >>>> +{ >>>> + u8 brdcfg15, brdcfg9; >>>> + >>>> + if (hwconfig("qe") && hwconfig("tdm")) { >>> >>> >>> This is called before environmental variables are relocated to DDR. It >>> will cause a warning. Please use hwconfig_f. >>> >> >> Please fix this patch with a new version. No need to submit other patches >> in this set. > > This upstream patch, qe_board_setup() is called in misc_init_r , it is correct, > Doesn't need to change. > OK. Thanks. York