public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tools: make imxheader size align on page size
Date: Thu, 17 Apr 2014 10:50:13 +0200	[thread overview]
Message-ID: <534F95C5.9020607@denx.de> (raw)
In-Reply-To: <fa1bf19a6bd528e63cdef2db290460e9@agner.ch>

Hi Stefan,

On 16/04/2014 15:36, Stefan Agner wrote:

>>>
>>> Can you better explain this ? There is only one board in mainline with
>>> vf610. CONFIG_SYS_TEXT_BASE is set to 0x3f008000. I cannot get the
>>> offset in your example. Are you referring to NAND page ? But if the
>>> header must be aligned with the NAND page, this is pretty bad because we
>>> have to adjust the header depending on the selected NAND chip. I do not
>>> see this limitation in the manual.
>> I've not submitted my board yet, I altered it to use 0x3f400800 as
>> CONFIG_SYS_TEXT_BASE. I just realize that a header length of 0x7fc
>> doesn't fit with 0x3f400404 even though (that would be 0x3f400004 if
>> anything). But the mkimage utility reports
>> Load Address: 3f400420
>> Entry Point:  3f400800
>> I'm a bit confused now, why is the header only 0x400 now?
> 
> Ok I checked this again, the header total size is _not_ 0x7fc, thats
> imximage_init_loadsize, which is the header size + flash load size
> (0x400 for NAND). 
> 
> The header total size is 0x3fc (sizeof(imx_header_v2_t)) right now. This
> patch would make alter it to be exactly 0x400.

This renforces my suspect. Making the image bigger, it seems that the
SOC loads more data as before.

However, reading in the manual, the initial load image (what the SOC
should load initially) is 4K (Table 19.37), and adding 4 bytes should
have no influence.

> 
> In case this discussion ends up adding this padding word, I will send a
> new patch with correct numbers and better description.

It is not clear what is the cause of the issue and then which is the
solution. Adding the pad at the moment seems only a work-around for you.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2014-04-17  8:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-16 13:29 [U-Boot] [PATCH] tools: make imxheader size align on page size stefan at agner.ch
2014-04-16 15:44 ` Stefano Babic
2014-04-16 13:17   ` Stefan Agner
2014-04-16 13:36     ` Stefan Agner
2014-04-17  8:50       ` Stefano Babic [this message]
2014-04-23  2:34         ` Stefan Agner
2014-04-23 15:19           ` Stefano Babic
2014-04-23  9:55             ` Stefan Agner
2014-04-23 18:07               ` Stefano Babic
2014-04-17 12:34     ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=534F95C5.9020607@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox