From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, V2, 2/4] aes: Move the AES-128-CBC encryption function to common code
Date: Fri, 18 Apr 2014 10:10:10 -0600 [thread overview]
Message-ID: <53514E62.2090204@wwwdotorg.org> (raw)
In-Reply-To: <20140327165910.GF16360@bill-the-cat>
On 03/27/2014 10:59 AM, Tom Rini wrote:
> On Wed, Mar 05, 2014 at 07:58:37PM +0100, Marek Vasut wrote:
>
>> Move the AES-128-CBC encryption function implemented in tegra20-common/crypto.c
>> into lib/aes.c . This is well re-usable common code. Moreover, clean the code up
>> a bit and fix the kerneldoc-style annotations.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>
> Applied to u-boot/next (with a reword to rewrap), thanks!
BTW, this breaks compilation on NVIDIA Tegra Seaboard.
Tom R fixed most of the issue with "ARM:tegra20: Remove aes debug
prints", but the following still remains:
> arch/arm/cpu/tegra20-common/crypto.c: In function ?sign_object?:
> arch/arm/cpu/tegra20-common/crypto.c:74:3: warning: implicit declaration of function ?apply_cbc_chain_data? [-Wimplicit-function-declaration]
> arch/arm/cpu/tegra20-common/crypto.c: In function ?sign_object?:
> arch/arm/cpu/tegra20-common/crypto.c:74:3: warning: implicit declaration of function ?apply_cbc_chain_data? [-Wimplicit-function-declaration]
> arch/arm/cpu/built-in.o: In function `sign_object':
> .../arch/arm/cpu/tegra20-common/crypto.c:74: undefined reference to `apply_cbc_chain_data'
> .../arch/arm/cpu/tegra20-common/crypto.c:78: undefined reference to `apply_cbc_chain_data'
next prev parent reply other threads:[~2014-04-18 16:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 18:58 [U-Boot] [PATCH 1/4] aes: Fix kerneldoc for aes.h Marek Vasut
2014-03-05 18:58 ` [U-Boot] [PATCH V2 2/4] aes: Move the AES-128-CBC encryption function to common code Marek Vasut
2014-03-27 16:59 ` [U-Boot] [U-Boot, V2, " Tom Rini
2014-04-18 16:10 ` Stephen Warren [this message]
2014-03-05 18:58 ` [U-Boot] [PATCH 3/4] aes: Implement AES-128-CBC decryption function Marek Vasut
2014-03-27 16:59 ` [U-Boot] [U-Boot, " Tom Rini
2014-03-05 18:58 ` [U-Boot] [PATCH 4/4] aes: Add 'aes' command to access AES-128-CBC Marek Vasut
2014-03-27 16:59 ` [U-Boot] [U-Boot, " Tom Rini
2014-03-27 16:59 ` [U-Boot] [U-Boot,1/4] aes: Fix kerneldoc for aes.h Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53514E62.2090204@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox