From: Bo Shen <voice.shen@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] lib/sha256: fix compile on some hosts
Date: Sun, 20 Apr 2014 21:18:07 +0800 [thread overview]
Message-ID: <5353C90F.80607@gmail.com> (raw)
In-Reply-To: <1397982855-12338-1-git-send-email-andreas.devel@googlemail.com>
Hi Andreas,
On 04/20/2014 04:34 PM, Andreas Bie?mann wrote:
> Commit 2842c1c24269a05142802d25520e7cb9035e456c introduced lib/sha256 into
> mkimage. Since then it will be compiled with HOSTCC which may produce errors
> on some systems. Most BSD systems (like OS X for me) do not ship a
> linux/string.h which will lead to take the U-Boot provided
> include/linux/string.h in the end. This header howver is completely wrong
s/howver/however
> here. Just take the string.h if compiling with HOSTCC and linux/string.h when
> not.
>
> Signed-off-by: Andreas Bie?mann <andreas.devel@googlemail.com>
> Cc: Heiko Schocher <hs@denx.de>
> ---
>
> lib/sha256.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lib/sha256.c b/lib/sha256.c
> index 3212bab..b1085ea 100644
> --- a/lib/sha256.c
> +++ b/lib/sha256.c
> @@ -8,9 +8,11 @@
>
> #ifndef USE_HOSTCC
> #include <common.h>
> +#include <linux/string.h>
> +#else
> +#include <string.h>
> #endif /* USE_HOSTCC */
> #include <watchdog.h>
> -#include <linux/string.h>
> #include <sha256.h>
>
> /*
Best Regards,
Bo Shen
next prev parent reply other threads:[~2014-04-20 13:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-20 8:34 [U-Boot] [PATCH] lib/sha256: fix compile on some hosts Andreas Bießmann
2014-04-20 13:18 ` Bo Shen [this message]
2014-04-25 4:59 ` Heiko Schocher
2014-05-13 1:52 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5353C90F.80607@gmail.com \
--to=voice.shen@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox