From: Jon Loeliger <jon.loeliger@oracle.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Revert "build: Use filechk rules to create and update u-boot.lds"
Date: Mon, 21 Apr 2014 09:35:50 -0500 [thread overview]
Message-ID: <53552CC6.8090405@oracle.com> (raw)
In-Reply-To: <1398047587-20247-1-git-send-email-yamada.m@jp.panasonic.com>
On 04/20/2014 09:33 PM, Masahiro Yamada wrote:
> This reverts commit a8b993eb81c142a439c24b871a2317f765fe5397.
>
> Commit a8b993eb claims it fixes u-boot.lds rule by replacing
> $(call if_changed) with $(call filechk).
>
> But the problem had already been fixed by commit 395e60cd
> a few days before commit a8b993eb was posted.
Bummer. Sorry about that. I didn't see Masahiro's patch.
> What is worse is
> $(call filechk) is too strong to fix the problem and looks weird.
I'm sure I don't understand that critique at all. "Looks weird"?
However, your patch (395e60cdc) is better in that it catches both
the regular top-level and the SPL build's load scripts. Mine did not.
jdl
next prev parent reply other threads:[~2014-04-21 14:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 2:33 [U-Boot] [PATCH] Revert "build: Use filechk rules to create and update u-boot.lds" Masahiro Yamada
2014-04-21 14:35 ` Jon Loeliger [this message]
2014-04-22 1:32 ` Masahiro Yamada
2014-04-23 12:45 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53552CC6.8090405@oracle.com \
--to=jon.loeliger@oracle.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox