From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] config: enable CMD_BMP when API+LCD is enabled
Date: Tue, 22 Apr 2014 10:00:54 -0600 [thread overview]
Message-ID: <53569236.4060303@wwwdotorg.org> (raw)
In-Reply-To: <CAPnjgZ3vqeaBHgumaK+1gKD=gNabcxVhXCpyVGKZs8nsmH9PSA@mail.gmail.com>
On 04/21/2014 05:31 PM, Simon Glass wrote:
> Hi Stephen,
>
> On 18 April 2014 11:15, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> When both CONFIG_API and CONFIG_LCD are enabled, the API code calls
>> lcd_display_bitmap(). That isn't compiled unless either CONFIG_CMD_BMP
>> or CONFIG_SPLASH_SCREEN is enabled. In order to prevent build problems,
>> have config_fallbacks.h enable CONFIG_CMD_BMP when both API and LCD are
>> enabled.
>>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> I do wonder whether it might be better to #error in this case?
I see it rather like a "select" in Kconfig. (although perhaps this would
end up being a depends rather than a select)
next prev parent reply other threads:[~2014-04-22 16:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-18 17:15 [U-Boot] [PATCH] config: enable CMD_BMP when API+LCD is enabled Stephen Warren
2014-04-21 23:31 ` Simon Glass
2014-04-22 16:00 ` Stephen Warren [this message]
2014-05-05 9:44 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53569236.4060303@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox