From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Tue, 22 Apr 2014 10:00:54 -0600 Subject: [U-Boot] [PATCH] config: enable CMD_BMP when API+LCD is enabled In-Reply-To: References: <1397841355-22609-1-git-send-email-swarren@wwwdotorg.org> Message-ID: <53569236.4060303@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/21/2014 05:31 PM, Simon Glass wrote: > Hi Stephen, > > On 18 April 2014 11:15, Stephen Warren wrote: >> >> From: Stephen Warren >> >> When both CONFIG_API and CONFIG_LCD are enabled, the API code calls >> lcd_display_bitmap(). That isn't compiled unless either CONFIG_CMD_BMP >> or CONFIG_SPLASH_SCREEN is enabled. In order to prevent build problems, >> have config_fallbacks.h enable CONFIG_CMD_BMP when both API and LCD are >> enabled. >> >> Signed-off-by: Stephen Warren > > Reviewed-by: Simon Glass > > I do wonder whether it might be better to #error in this case? I see it rather like a "select" in Kconfig. (although perhaps this would end up being a depends rather than a select)