* [U-Boot] [PATCH] config: enable CMD_BMP when API+LCD is enabled
@ 2014-04-18 17:15 Stephen Warren
2014-04-21 23:31 ` Simon Glass
2014-05-05 9:44 ` Anatolij Gustschin
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Warren @ 2014-04-18 17:15 UTC (permalink / raw)
To: u-boot
From: Stephen Warren <swarren@nvidia.com>
When both CONFIG_API and CONFIG_LCD are enabled, the API code calls
lcd_display_bitmap(). That isn't compiled unless either CONFIG_CMD_BMP
or CONFIG_SPLASH_SCREEN is enabled. In order to prevent build problems,
have config_fallbacks.h enable CONFIG_CMD_BMP when both API and LCD are
enabled.
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
include/config_fallbacks.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/include/config_fallbacks.h b/include/config_fallbacks.h
index e6fb47be0bd7..b304a4103def 100644
--- a/include/config_fallbacks.h
+++ b/include/config_fallbacks.h
@@ -71,6 +71,10 @@
#define CONFIG_LIB_RAND
#endif
+#if defined(CONFIG_API) && defined(CONFIG_LCD)
+#define CONFIG_CMD_BMP
+#endif
+
#ifndef CONFIG_SYS_PROMPT
#define CONFIG_SYS_PROMPT "=> "
#endif
--
1.8.1.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] config: enable CMD_BMP when API+LCD is enabled
2014-04-18 17:15 [U-Boot] [PATCH] config: enable CMD_BMP when API+LCD is enabled Stephen Warren
@ 2014-04-21 23:31 ` Simon Glass
2014-04-22 16:00 ` Stephen Warren
2014-05-05 9:44 ` Anatolij Gustschin
1 sibling, 1 reply; 4+ messages in thread
From: Simon Glass @ 2014-04-21 23:31 UTC (permalink / raw)
To: u-boot
Hi Stephen,
On 18 April 2014 11:15, Stephen Warren <swarren@wwwdotorg.org> wrote:
>
> From: Stephen Warren <swarren@nvidia.com>
>
> When both CONFIG_API and CONFIG_LCD are enabled, the API code calls
> lcd_display_bitmap(). That isn't compiled unless either CONFIG_CMD_BMP
> or CONFIG_SPLASH_SCREEN is enabled. In order to prevent build problems,
> have config_fallbacks.h enable CONFIG_CMD_BMP when both API and LCD are
> enabled.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
I do wonder whether it might be better to #error in this case?
Regards,
Simon
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] config: enable CMD_BMP when API+LCD is enabled
2014-04-21 23:31 ` Simon Glass
@ 2014-04-22 16:00 ` Stephen Warren
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Warren @ 2014-04-22 16:00 UTC (permalink / raw)
To: u-boot
On 04/21/2014 05:31 PM, Simon Glass wrote:
> Hi Stephen,
>
> On 18 April 2014 11:15, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> When both CONFIG_API and CONFIG_LCD are enabled, the API code calls
>> lcd_display_bitmap(). That isn't compiled unless either CONFIG_CMD_BMP
>> or CONFIG_SPLASH_SCREEN is enabled. In order to prevent build problems,
>> have config_fallbacks.h enable CONFIG_CMD_BMP when both API and LCD are
>> enabled.
>>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> I do wonder whether it might be better to #error in this case?
I see it rather like a "select" in Kconfig. (although perhaps this would
end up being a depends rather than a select)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] config: enable CMD_BMP when API+LCD is enabled
2014-04-18 17:15 [U-Boot] [PATCH] config: enable CMD_BMP when API+LCD is enabled Stephen Warren
2014-04-21 23:31 ` Simon Glass
@ 2014-05-05 9:44 ` Anatolij Gustschin
1 sibling, 0 replies; 4+ messages in thread
From: Anatolij Gustschin @ 2014-05-05 9:44 UTC (permalink / raw)
To: u-boot
On Fri, 18 Apr 2014 11:15:55 -0600
Stephen Warren <swarren@wwwdotorg.org> wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> When both CONFIG_API and CONFIG_LCD are enabled, the API code calls
> lcd_display_bitmap(). That isn't compiled unless either CONFIG_CMD_BMP
> or CONFIG_SPLASH_SCREEN is enabled. In order to prevent build problems,
> have config_fallbacks.h enable CONFIG_CMD_BMP when both API and LCD are
> enabled.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> include/config_fallbacks.h | 4 ++++
> 1 file changed, 4 insertions(+)
applied to u-boot-video/master. Thanks!
Anatolij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-05 9:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-18 17:15 [U-Boot] [PATCH] config: enable CMD_BMP when API+LCD is enabled Stephen Warren
2014-04-21 23:31 ` Simon Glass
2014-04-22 16:00 ` Stephen Warren
2014-05-05 9:44 ` Anatolij Gustschin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox