[U-Boot] [PATCH] spl: consolidate arch/arm/include/asm/arch-*/spl.h

Tim Harvey
2014-05-16T06:16:09Z

On Mon, Apr 28, 2014 at 1:16 AM, Masahiro Yamada
<yamada.m@jp.panasonic.com> wrote:
>
> Hi Tom,
>
> On Fri, 25 Apr 2014 14:52:06 -0400
> Tom Rini <trini@ti.com> wrote:
>
> > On Wed, Apr 16, 2014 at 03:44:36PM +0900, Masahiro Yamada wrote:
> >
> > > arch/arm/include/asm/spl.h requires all SoCs to have
> > > arch/arm/include/asm/arch-*/spl.h.
> > >
> > > But many of them just define BOOT_DEVICE_* macros.
> > >
> > > Those macros are used in the "switch (boot_device) { ... }"
> > > statement in common/spl/spl.c.
> > >
> > > So they should not be archtecture specific, but described as
> > > a simpile enumeration.
> > >
> > > This commit merge most of arch/arm/include/asm/arch-*/spl.h
> > > into arch/arm/include/asm/spl.h.
> > >
> > > With a little more effort, arch-zynq/spl.h and arch-socfpga/spl.h
> > > will be merged, while I am not sure about OMAP and Exynos.
> >
> > The problem is that on TI platforms these values have meaning defined by
> > ROM (which changes occasionally). When ROM starts us up, we get a
> > little bit of info that says "I found and loaded you on ...". So while
> > we could move towards moving BOOT_DEVICE_FOO into <spl.h> we'd need in
> > arch/arm/cpu/armv7/omap-common/boot-common.c some logic to translate
> > from ROM numbers to U-Boot numbers.
>
> Could you apply my patch first and fix the OMAP translation logic lator?
>
> I want to stop duplication of similar spl.h headers.
>
> Best Regards
> Masahiro Yamada

Tom / Masahiro,

Any update on this? This is a very useful cleanup and there is at
least one pending patch series that depend on it.

Regards,

Tim