From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 07/11] MX6: use macro building for MX6Q/MX6DL iomux regs
Date: Wed, 23 Apr 2014 17:30:08 +0200 [thread overview]
Message-ID: <5357DC80.1080603@denx.de> (raw)
In-Reply-To: <CAJ+vNU3B1wEJ6eAQuzPdCsftx6avDqZZrktaz=RBA2NztcoT4w@mail.gmail.com>
Hi Tim,
On 09/04/2014 17:46, Tim Harvey wrote:
> On Wed, Apr 9, 2014 at 7:57 AM, Nikita Kiryanov <nikita@compulab.co.il> wrote:
>> Hi Tim,
>>
>>
>> On 04/03/2014 09:01 AM, Tim Harvey wrote:
>>>
>>> This is an attempt at using a macro to allow mx6dl-ddr.h and
>>> mx6q-ddr.h registers to be used together which is needed for an SPL
>>> bootloader
>>> that can run on either CPU's and must configure MMDC iomux dynamically.
>>>
>>> I am trying to come up with a solution similar to Eric's approach with the
>>> similar issue regarding IMX pinmux but this approach is broken in that
>>> imximage
>>> will choke on the cfgtmp file due to the fact that the pre-processor won't
>>> use the enum's as it did the #defines. I'm looking for some positive
>>> suggestions here or perhaps someone else can come up with a solution for
>>> this
>>> particular issue which I haven't been able to resolve.
>>
It seems that this patch breaks all other boards. I tried myself and
after preprocessing the .cfg file, the resulting file contains
structures that mkimage cannot process.
For example, building udoo:
MKIMAGE u-boot.imx
Invalid imximage commands Type - valid names are: BOOT_FROM,
BOOT_OFFSET, DATA, CSF, IMAGE_VERSION
Error: board/udoo/udoo.cfg.cfgtmp[44] - Invalid command(struct)
In fact, board/udoo/udoo.cfg.cfgtmp contains the structures from
/mx6-ddr.h (this patch):
# 15 "include/config.h" 2
# 23 "board/udoo/udoo.cfg" 2
# 1
"/home/stefano/Projects/imx/u-boot-imx/arch/arm/include/asm/arch/mx6-ddr.h"
1
# 15
"/home/stefano/Projects/imx/u-boot-imx/arch/arm/include/asm/arch/mx6-ddr.h"
struct mx6_mmdc_ioregs {
u32 mmdc_dram_dqm0;
u32 mmdc_dram_dqm1;
u32 mmdc_dram_dqm2;
u32 mmdc_dram_dqm3;
u32 mmdc_dram_dqm4;
u32 mmdc_dram_dqm5;
u32 mmdc_dram_dqm6;
u32 mmdc_dram_dqm7;
u32 mmdc_dram_cas;
u32 mmdc_dram_ras;
and then mkimage stops.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2014-04-23 15:30 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 6:01 [U-Boot] [PATCH 00/11] MX6: SPL NAND support Tim Harvey
2014-04-03 6:01 ` [U-Boot] [PATCH 01/11] SPL: NAND: remove CONFIG_SYS_NAND_PAGE_SIZE Tim Harvey
2014-04-04 2:33 ` Masahiro Yamada
2014-04-09 14:55 ` Nikita Kiryanov
2014-04-14 11:38 ` Stefano Babic
2014-04-17 14:18 ` Tim Harvey
2014-04-18 22:23 ` Scott Wood
2014-04-03 6:01 ` [U-Boot] [PATCH 02/11] SPL: NAND: add support for mxs nand Tim Harvey
2014-04-14 11:38 ` Stefano Babic
2014-04-03 6:01 ` [U-Boot] [PATCH 03/11] MX6: provide linker script for SPL Tim Harvey
2014-04-09 14:55 ` Nikita Kiryanov
2014-04-14 12:02 ` Stefano Babic
2014-04-17 6:27 ` Tim Harvey
2014-04-18 21:10 ` Otavio Salvador
2014-04-03 6:01 ` [U-Boot] [PATCH 04/11] MX6: add common SPL configuration Tim Harvey
2014-04-09 14:55 ` Nikita Kiryanov
2014-04-09 15:32 ` Tim Harvey
2014-04-10 14:37 ` Nikita Kiryanov
2014-04-10 21:04 ` Scott Wood
2014-04-03 6:01 ` [U-Boot] [PATCH 05/11] MX6: add boot device support SPL Tim Harvey
2014-04-14 12:27 ` Stefano Babic
2014-04-17 6:16 ` Tim Harvey
2014-04-17 8:59 ` Stefano Babic
2014-04-03 6:01 ` [U-Boot] [PATCH 06/11] MX6: add struct for sharing data between SPL and uboot Tim Harvey
2014-04-09 14:55 ` Nikita Kiryanov
2014-04-14 12:35 ` Stefano Babic
2014-04-17 6:07 ` Tim Harvey
2014-04-17 9:30 ` Stefano Babic
2014-04-17 11:22 ` Igor Grinberg
2014-04-17 11:44 ` Stefano Babic
2014-04-18 6:35 ` Tim Harvey
2014-04-20 7:52 ` Igor Grinberg
2014-04-21 18:28 ` Tim Harvey
2014-04-22 7:44 ` Igor Grinberg
2014-04-03 6:01 ` [U-Boot] [PATCH 07/11] MX6: use macro building for MX6Q/MX6DL iomux regs Tim Harvey
2014-04-09 14:57 ` Nikita Kiryanov
2014-04-09 15:46 ` Tim Harvey
2014-04-10 14:08 ` Nikita Kiryanov
2014-04-10 14:51 ` Nikita Kiryanov
2014-04-11 5:23 ` Tim Harvey
2014-04-23 17:07 ` Stefano Babic
2014-04-23 19:00 ` Eric Nelson
2014-04-24 7:07 ` Igor Grinberg
2014-04-24 5:21 ` Tim Harvey
2014-04-23 15:30 ` Stefano Babic [this message]
2014-04-03 6:01 ` [U-Boot] [PATCH 08/11] MX6: add mmdc configuration for MX6Q/MX6DL Tim Harvey
2014-04-03 6:01 ` [U-Boot] [PATCH 09/11] IMX: add additional function for pinmux using an array Tim Harvey
2014-04-09 14:56 ` Nikita Kiryanov
2014-04-09 15:40 ` Tim Harvey
2014-04-10 14:41 ` Nikita Kiryanov
2014-04-23 5:03 ` Tim Harvey
2014-04-03 6:01 ` [U-Boot] [PATCH 10/11] ventana: auto-configure for IMX6Q vs IMX6DL Tim Harvey
2014-04-23 17:31 ` Stefano Babic
2014-04-24 5:04 ` Tim Harvey
2014-04-03 6:01 ` [U-Boot] [PATCH 11/11] ventana: switch to SPL Tim Harvey
2014-04-03 18:52 ` Tim Harvey
2014-04-23 18:03 ` Stefano Babic
2014-04-24 8:06 ` Tim Harvey
2014-04-24 8:18 ` Stefano Babic
2014-04-24 8:22 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5357DC80.1080603@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox