* [U-Boot] [PATCH] powerpc/mpc85xx: Remove QE firmware copy from NAND
@ 2014-04-21 5:16 Prabhakar Kushwaha
2014-04-22 19:31 ` Scott Wood
2014-04-23 21:52 ` York Sun
0 siblings, 2 replies; 4+ messages in thread
From: Prabhakar Kushwaha @ 2014-04-21 5:16 UTC (permalink / raw)
To: u-boot
qe_init() does not use data copied from NAND. Thise code is not tested or
complied causing compilation error during NAND boot
So, remove QE firmware copy from NAND to ddr.
Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
---
arch/powerpc/cpu/mpc85xx/cpu_init.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init.c b/arch/powerpc/cpu/mpc85xx/cpu_init.c
index ea41ffc..36ef232 100644
--- a/arch/powerpc/cpu/mpc85xx/cpu_init.c
+++ b/arch/powerpc/cpu/mpc85xx/cpu_init.c
@@ -925,19 +925,6 @@ void cpu_secondary_init_r(void)
#endif
#ifdef CONFIG_QE
-#ifdef CONFIG_SYS_QE_FMAN_FW_IN_NAND
- int ret;
- size_t fw_length = CONFIG_SYS_QE_FMAN_FW_LENGTH;
-
- /* load QE firmware from NAND flash to DDR first */
- ret = nand_read(&nand_info[0], (loff_t)CONFIG_SYS_QE_FMAN_FW_IN_NAND,
- &fw_length, (u_char *)CONFIG_SYS_QE_FW_ADDR);
-
- if (ret && ret == -EUCLEAN) {
- printf ("NAND read for QE firmware at offset %x failed %d\n",
- CONFIG_SYS_QE_FMAN_FW_IN_NAND, ret);
- }
-#endif
qe_init(qe_base);
qe_reset();
#endif
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] powerpc/mpc85xx: Remove QE firmware copy from NAND
2014-04-21 5:16 [U-Boot] [PATCH] powerpc/mpc85xx: Remove QE firmware copy from NAND Prabhakar Kushwaha
@ 2014-04-22 19:31 ` Scott Wood
2014-04-23 3:44 ` Prabhakar Kushwaha
2014-04-23 21:52 ` York Sun
1 sibling, 1 reply; 4+ messages in thread
From: Scott Wood @ 2014-04-22 19:31 UTC (permalink / raw)
To: u-boot
On Mon, 2014-04-21 at 10:46 +0530, Prabhakar Kushwaha wrote:
> qe_init() does not use data copied from NAND. Thise code is not tested or
> complied causing compilation error during NAND boot
>
> So, remove QE firmware copy from NAND to ddr.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
Where does the QE firmware come from when booting from NAND?
-Scott
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] powerpc/mpc85xx: Remove QE firmware copy from NAND
2014-04-22 19:31 ` Scott Wood
@ 2014-04-23 3:44 ` Prabhakar Kushwaha
0 siblings, 0 replies; 4+ messages in thread
From: Prabhakar Kushwaha @ 2014-04-23 3:44 UTC (permalink / raw)
To: u-boot
On 4/23/2014 1:01 AM, Scott Wood wrote:
> On Mon, 2014-04-21 at 10:46 +0530, Prabhakar Kushwaha wrote:
>> qe_init() does not use data copied from NAND. Thise code is not tested or
>> complied causing compilation error during NAND boot
>>
>> So, remove QE firmware copy from NAND to ddr.
>>
>> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> Where does the QE firmware come from when booting from NAND?
>
>
QE firmware load from NAND is currently not being supported.
Even if it is supported, cpu_init.c file should not have code of
loading QE firmware.
-prabhakar
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] powerpc/mpc85xx: Remove QE firmware copy from NAND
2014-04-21 5:16 [U-Boot] [PATCH] powerpc/mpc85xx: Remove QE firmware copy from NAND Prabhakar Kushwaha
2014-04-22 19:31 ` Scott Wood
@ 2014-04-23 21:52 ` York Sun
1 sibling, 0 replies; 4+ messages in thread
From: York Sun @ 2014-04-23 21:52 UTC (permalink / raw)
To: u-boot
On 04/20/2014 10:16 PM, Prabhakar Kushwaha wrote:
> qe_init() does not use data copied from NAND. Thise code is not tested or
> complied causing compilation error during NAND boot
>
> So, remove QE firmware copy from NAND to ddr.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> ---
Applied to u-boot-mpc85xx/master, thanks.
York
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-04-23 21:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-21 5:16 [U-Boot] [PATCH] powerpc/mpc85xx: Remove QE firmware copy from NAND Prabhakar Kushwaha
2014-04-22 19:31 ` Scott Wood
2014-04-23 3:44 ` Prabhakar Kushwaha
2014-04-23 21:52 ` York Sun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox