[U-Boot] [RFC PATCH 1/2] mkimage: add atmelimage

Andreas Bießmann
2014-04-24T05:23:59Z

Hi Bo,

On 24.04.14 05:09, Bo Shen wrote:
> Hi Andreas,
>
> On 04/23/2014 10:29 PM, Andreas Bie?mann wrote:
>> +static void atmel_set_header(void *ptr, struct stat *sbuf, int ifd,
>> + struct image_tool_params *params)
>> +{
>> + /* just save the image size into 6'th interrupt vector */
>> + uint32_t *ints = (uint32_t *)ptr;
>> +
>> + /* The size must not exceed 64 Kbytes */
>> + if (sbuf->st_size < 64 * 1024)
>> + ints[5] = sbuf->st_size;
>> +}
>
> Here, just a reminder.
>
> As only sama5d3xek support SPL, so it won't hurt. However, if plan to
> add other Atmel boards with SPL support, we need check it more strictly
> (e.g: sam9x5 only support up to 24k bytes).

Well, I'd like to have other devices also support SPL. I think we should
just remove that check here. We should use the linker for size checking.

Best regards

Andreas Bie?mann