From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QW5kcmVhcyBCaWXDn21hbm4=?= Date: Thu, 24 Apr 2014 07:23:59 +0200 Subject: [U-Boot] [RFC PATCH 1/2] mkimage: add atmelimage In-Reply-To: <53588058.5050900@atmel.com> References: <1398263365-17931-1-git-send-email-andreas.devel@googlemail.com> <1398263365-17931-2-git-send-email-andreas.devel@googlemail.com> <53588058.5050900@atmel.com> Message-ID: <53589FEF.5050008@googlemail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Bo, On 24.04.14 05:09, Bo Shen wrote: > Hi Andreas, > > On 04/23/2014 10:29 PM, Andreas Bie?mann wrote: >> +static void atmel_set_header(void *ptr, struct stat *sbuf, int ifd, >> + struct image_tool_params *params) >> +{ >> + /* just save the image size into 6'th interrupt vector */ >> + uint32_t *ints = (uint32_t *)ptr; >> + >> + /* The size must not exceed 64 Kbytes */ >> + if (sbuf->st_size < 64 * 1024) >> + ints[5] = sbuf->st_size; >> +} > > Here, just a reminder. > > As only sama5d3xek support SPL, so it won't hurt. However, if plan to > add other Atmel boards with SPL support, we need check it more strictly > (e.g: sam9x5 only support up to 24k bytes). Well, I'd like to have other devices also support SPL. I think we should just remove that check here. We should use the linker for size checking. Best regards Andreas Bie?mann