public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] power: make pfuze100 be able to coexist with other pmics
Date: Thu, 24 Apr 2014 10:03:12 +0200	[thread overview]
Message-ID: <5358C540.9080702@denx.de> (raw)
In-Reply-To: <1398228839-29780-2-git-send-email-tharvey@gateworks.com>

Hi Tim,

On 23/04/2014 06:53, Tim Harvey wrote:
> Avoid uding pmic_init() as this forces the model of only allowing a
> single PMIC driver to be built at a time.
> 
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
>  drivers/power/pmic/pmic_pfuze100.c | 2 +-
>  include/power/pfuze100_pmic.h      | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/power/pmic/pmic_pfuze100.c b/drivers/power/pmic/pmic_pfuze100.c
> index 22c1f15..21f12d2 100644
> --- a/drivers/power/pmic/pmic_pfuze100.c
> +++ b/drivers/power/pmic/pmic_pfuze100.c
> @@ -11,7 +11,7 @@
>  #include <power/pmic.h>
>  #include <power/pfuze100_pmic.h>
>  
> -int pmic_init(unsigned char bus)
> +int power_pfuze100_init(unsigned char bus)
>  {
>  	static const char name[] = "PFUZE100_PMIC";
>  	struct pmic *p = pmic_alloc();
> diff --git a/include/power/pfuze100_pmic.h b/include/power/pfuze100_pmic.h
> index 2a9032a..444aba6 100644
> --- a/include/power/pfuze100_pmic.h
> +++ b/include/power/pfuze100_pmic.h
> @@ -93,4 +93,5 @@ enum {
>  #define SWBST_MODE_AUTO	(2 << 2)
>  #define SWBST_MODE_APS	(2 << 3)
>  
> +int power_pfuze100_init(unsigned char bus);

This is a change in the PMIC framework API and must be documented.

Currently, we support multiple instances of the same PMIC, but not
different PMIC on the same board.

We could add a CONFIG_MULTIPLE_PMIC, that must be added to the
documentation, and each driver will define pmic_init() if it is not define:

#ifndef CONFIG_MULTIPLE_PMIC
#define pmic_init power_pfuze100_init
#endif

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2014-04-24  8:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-23  4:53 [U-Boot] [PATCH 0/4] ventana: Add LTC3676 PMIC support Tim Harvey
2014-04-23  4:53 ` [U-Boot] [PATCH 1/4] power: make pfuze100 be able to coexist with other pmics Tim Harvey
2014-04-24  8:03   ` Stefano Babic [this message]
2014-04-24  8:19     ` Tim Harvey
2014-04-24  8:30       ` Stefano Babic
2014-05-09 12:44   ` Stefano Babic
2014-04-23  4:53 ` [U-Boot] [PATCH 2/4] ventana: use non-generic pfuze100 init Tim Harvey
2014-05-09 12:44   ` Stefano Babic
2014-04-23  4:53 ` [U-Boot] [PATCH 3/4] power: Add support for LTC3676 PMIC Tim Harvey
2014-04-24  8:05   ` Stefano Babic
2014-05-09 12:43   ` Stefano Babic
2014-04-23  4:53 ` [U-Boot] [PATCH 4/4] [PATCH] ventana: Add support for the " Tim Harvey
2014-04-24  8:08   ` Stefano Babic
2014-05-05 15:22     ` Tim Harvey
2014-05-09 12:42       ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5358C540.9080702@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox