[U-Boot] [PATCH 04/11] kconfig: add basic Kconfig files

Simon Glass
2014-04-30T19:16:28Z

Hi Masahiro,

On 29 April 2014 21:22, Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:
> Hi Simon,
>
>> > +
>> > +config SPL_BUILD
>> > + bool
>> > + depends on BUILD_MODE="SPL" || BUILD_MODE="TPL"
>>
>> What is the TPL term for?
>
> Please note that both CONFIG_SPL_BUILD and CONFIG_TPL_BUILD
> must be defined during the build of TPL image.
>
> To sum up in a matrix, the definition of the these macros is like this:
>
> CONFIG_SPL_BUILD CONFIG_TPL_BUILD
> non-SPL build: undefined undefined
> SPL build defined undefined
> TPL build defined defined
>
>
> Maybe do you think it looks weird? ( Me too.)
> But the implementation has been like this
> since TPL infrastructure was introduced by commit 3aa29de.
>
> Defining only CONFIG_TPL_BUILD does not work.

OK, thanks for explaining this. It seems wrong to me, but that should
be a separate discussion for later and does not affect your series.

Regards,
Simon