* [U-Boot] [PATCH] ARM: imx6: nitrogen6x: Enable CONFIG_SYS_GENERIC_BOARD
@ 2014-04-25 23:15 Eric Nelson
2014-04-28 5:05 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Eric Nelson @ 2014-04-25 23:15 UTC (permalink / raw)
To: u-boot
Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
---
Note that this seems a bit premature until we have some infrastructure
around DTB files in place, but we certainly don't want big hairy
warning messages on our boards.
Is anyone planning on pulling in at least the pinfunc and .dtsi
files for i.MX? I'm not sure how much else will be useful in U-Boot.
include/configs/nitrogen6x.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/configs/nitrogen6x.h b/include/configs/nitrogen6x.h
index f7e7315..895f36f 100644
--- a/include/configs/nitrogen6x.h
+++ b/include/configs/nitrogen6x.h
@@ -24,6 +24,7 @@
#define CONFIG_SETUP_MEMORY_TAGS
#define CONFIG_INITRD_TAG
#define CONFIG_REVISION_TAG
+#define CONFIG_SYS_GENERIC_BOARD
/* Size of malloc() pool */
#define CONFIG_SYS_MALLOC_LEN (10 * 1024 * 1024)
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] ARM: imx6: nitrogen6x: Enable CONFIG_SYS_GENERIC_BOARD
2014-04-25 23:15 [U-Boot] [PATCH] ARM: imx6: nitrogen6x: Enable CONFIG_SYS_GENERIC_BOARD Eric Nelson
@ 2014-04-28 5:05 ` Marek Vasut
2014-04-28 9:05 ` Stefano Babic
0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2014-04-28 5:05 UTC (permalink / raw)
To: u-boot
On Saturday, April 26, 2014 at 01:15:46 AM, Eric Nelson wrote:
You should learn to write sensible commit messages ;-)
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
> Note that this seems a bit premature until we have some infrastructure
> around DTB files in place, but we certainly don't want big hairy
> warning messages on our boards.
>
> Is anyone planning on pulling in at least the pinfunc and .dtsi
> files for i.MX? I'm not sure how much else will be useful in U-Boot.
>
> include/configs/nitrogen6x.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/configs/nitrogen6x.h b/include/configs/nitrogen6x.h
> index f7e7315..895f36f 100644
> --- a/include/configs/nitrogen6x.h
> +++ b/include/configs/nitrogen6x.h
> @@ -24,6 +24,7 @@
> #define CONFIG_SETUP_MEMORY_TAGS
> #define CONFIG_INITRD_TAG
> #define CONFIG_REVISION_TAG
> +#define CONFIG_SYS_GENERIC_BOARD
>
> /* Size of malloc() pool */
> #define CONFIG_SYS_MALLOC_LEN (10 * 1024 * 1024)
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] ARM: imx6: nitrogen6x: Enable CONFIG_SYS_GENERIC_BOARD
2014-04-28 5:05 ` Marek Vasut
@ 2014-04-28 9:05 ` Stefano Babic
2014-06-21 21:31 ` [U-Boot] [PATCH V2] imx: nitrogen6x: Add support for GENERIC_BOARD Eric Nelson
0 siblings, 1 reply; 6+ messages in thread
From: Stefano Babic @ 2014-04-28 9:05 UTC (permalink / raw)
To: u-boot
On 28/04/2014 07:05, Marek Vasut wrote:
> On Saturday, April 26, 2014 at 01:15:46 AM, Eric Nelson wrote:
>
> You should learn to write sensible commit messages ;-)
>
Well, the current main issue is the warning, but the subject already
says what is the change. IMHO the patch is ok. I will add myself by
merging the same commit message that Fabio adds for his patchset on the
same issue:
Enable CONFIG_SYS_GENERIC_BOARD, so that we get rid of the following
warning on
boot:
"Warning: Your board does not use generic board. Please read
doc/README.generic-board and take action. Boards not
upgraded by the late 2014 may break or be removed."
This completes the patch and address Marek's comment.
>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
>> ---
>> Note that this seems a bit premature until we have some infrastructure
>> around DTB files in place, but we certainly don't want big hairy
>> warning messages on our boards.
>>
>> Is anyone planning on pulling in at least the pinfunc and .dtsi
>> files for i.MX? I'm not sure how much else will be useful in U-Boot.
I have currently no projects in this direction, so personally I will not
work in a short amount of time on this topic. However, I agree that the
first thing for a DTS in U-Boot should be the pinmux.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH V2] imx: nitrogen6x: Add support for GENERIC_BOARD
2014-04-28 9:05 ` Stefano Babic
@ 2014-06-21 21:31 ` Eric Nelson
2014-06-21 21:41 ` Fabio Estevam
0 siblings, 1 reply; 6+ messages in thread
From: Eric Nelson @ 2014-06-21 21:31 UTC (permalink / raw)
To: u-boot
Enable CONFIG_SYS_GENERIC_BOARD, so that we get rid of the following
warning on boot:
"Warning: Your board does not use generic board. Please read
doc/README.generic-board and take action. Boards not
upgraded by the late 2014 may break or be removed."
Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
---
V2 expands on the commit message as requested by Mark and suggested by Stefano.
include/configs/nitrogen6x.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/configs/nitrogen6x.h b/include/configs/nitrogen6x.h
index b2b17ce..43d1971 100644
--- a/include/configs/nitrogen6x.h
+++ b/include/configs/nitrogen6x.h
@@ -26,6 +26,8 @@
#define CONFIG_REVISION_TAG
#define CONFIG_SYS_GENERIC_BOARD
+#define CONFIG_SYS_GENERIC_BOARD
+
/* Size of malloc() pool */
#define CONFIG_SYS_MALLOC_LEN (10 * 1024 * 1024)
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH V2] imx: nitrogen6x: Add support for GENERIC_BOARD
2014-06-21 21:31 ` [U-Boot] [PATCH V2] imx: nitrogen6x: Add support for GENERIC_BOARD Eric Nelson
@ 2014-06-21 21:41 ` Fabio Estevam
2014-06-22 15:04 ` Eric Nelson
0 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2014-06-21 21:41 UTC (permalink / raw)
To: u-boot
On Sat, Jun 21, 2014 at 6:31 PM, Eric Nelson
<eric.nelson@boundarydevices.com> wrote:
> --- a/include/configs/nitrogen6x.h
> +++ b/include/configs/nitrogen6x.h
> @@ -26,6 +26,8 @@
> #define CONFIG_REVISION_TAG
> #define CONFIG_SYS_GENERIC_BOARD
>
> +#define CONFIG_SYS_GENERIC_BOARD
> +
Looks like something went wrong here as we see
CONFIG_SYS_GENERIC_BOARD twice now :-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH V2] imx: nitrogen6x: Add support for GENERIC_BOARD
2014-06-21 21:41 ` Fabio Estevam
@ 2014-06-22 15:04 ` Eric Nelson
0 siblings, 0 replies; 6+ messages in thread
From: Eric Nelson @ 2014-06-22 15:04 UTC (permalink / raw)
To: u-boot
Thanks Fabio,
On 06/21/2014 02:41 PM, Fabio Estevam wrote:
> On Sat, Jun 21, 2014 at 6:31 PM, Eric Nelson
> <eric.nelson@boundarydevices.com> wrote:
>> --- a/include/configs/nitrogen6x.h
>> +++ b/include/configs/nitrogen6x.h
>> @@ -26,6 +26,8 @@
>> #define CONFIG_REVISION_TAG
>> #define CONFIG_SYS_GENERIC_BOARD
>>
>> +#define CONFIG_SYS_GENERIC_BOARD
>> +
>
> Looks like something went wrong here as we see
> CONFIG_SYS_GENERIC_BOARD twice now :-)
>
I guess that's what I get for looking in Patchwork
to see the status instead of the code!
Regards,
Eric
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-06-22 15:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-25 23:15 [U-Boot] [PATCH] ARM: imx6: nitrogen6x: Enable CONFIG_SYS_GENERIC_BOARD Eric Nelson
2014-04-28 5:05 ` Marek Vasut
2014-04-28 9:05 ` Stefano Babic
2014-06-21 21:31 ` [U-Boot] [PATCH V2] imx: nitrogen6x: Add support for GENERIC_BOARD Eric Nelson
2014-06-21 21:41 ` Fabio Estevam
2014-06-22 15:04 ` Eric Nelson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox