public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 6/6] PPC 85xx: Add qemu-ppce500 machine
Date: Mon, 28 Apr 2014 14:31:38 -0700	[thread overview]
Message-ID: <535EC8BA.9030008@freescale.com> (raw)
In-Reply-To: <43327C2A-316D-4CCA-86C1-D98FABD67638@suse.de>

On 04/28/2014 02:27 PM, Alexander Graf wrote:
>> I am thinking to add back "#ifdef CONFIG_QEMU_E500" you had for your v3 and
>> earlier version for the above change. Do you have any concerns?
>>
>> The reason I am proposing this is to use generic board architecture.
>> gd->fdt_blob is used by some other functions to detect if device tree exists.
>> Your change takes r3 from entry and treat it as device tree. It is not the case
>> for a normal metal SoC. I need to clear this variable.
> 
> No complaints at all from me here :)
> 

Thanks. I will submit a patch to fix it.

York

      reply	other threads:[~2014-04-28 21:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-20 12:52 [U-Boot] [PATCH v4 0/6] PPC 85xx: Add support for QEMU's ppce500 PV machine Alexander Graf
2014-02-20 12:52 ` [U-Boot] [PATCH v4 1/6] fdt_support: split fdt_getprop_u32_default Alexander Graf
2014-02-20 12:52 ` [U-Boot] [PATCH v4 2/6] fdt_support: Add helper function to read "ranges" property Alexander Graf
2014-02-20 12:52 ` [U-Boot] [PATCH v4 3/6] PPC: 85xx: Remove IVOR reset Alexander Graf
2014-02-20 12:52 ` [U-Boot] [PATCH v4 4/6] PPC: 85xx: Generalize DDR TLB mapping function Alexander Graf
2014-02-20 12:52 ` [U-Boot] [PATCH v4 5/6] PPC 85xx: Add ELF entry point Alexander Graf
2014-02-20 12:52 ` [U-Boot] [PATCH v4 6/6] PPC 85xx: Add qemu-ppce500 machine Alexander Graf
2014-02-20 15:59   ` Scott Wood
2014-03-19 18:49     ` York Sun
2014-04-11 14:38       ` Alexander Graf
2014-04-28 18:40   ` York Sun
2014-04-28 21:27     ` Alexander Graf
2014-04-28 21:31       ` York Sun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=535EC8BA.9030008@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox