From mboxrd@z Thu Jan 1 00:00:00 1970 From: York Sun Date: Mon, 28 Apr 2014 14:31:38 -0700 Subject: [U-Boot] [PATCH v4 6/6] PPC 85xx: Add qemu-ppce500 machine In-Reply-To: <43327C2A-316D-4CCA-86C1-D98FABD67638@suse.de> References: <1392900768-33843-1-git-send-email-agraf@suse.de> <1392900768-33843-7-git-send-email-agraf@suse.de> <535EA08F.50709@freescale.com> <43327C2A-316D-4CCA-86C1-D98FABD67638@suse.de> Message-ID: <535EC8BA.9030008@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/28/2014 02:27 PM, Alexander Graf wrote: >> I am thinking to add back "#ifdef CONFIG_QEMU_E500" you had for your v3 and >> earlier version for the above change. Do you have any concerns? >> >> The reason I am proposing this is to use generic board architecture. >> gd->fdt_blob is used by some other functions to detect if device tree exists. >> Your change takes r3 from entry and treat it as device tree. It is not the case >> for a normal metal SoC. I need to clear this variable. > > No complaints at all from me here :) > Thanks. I will submit a patch to fix it. York