public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/5] powerpc/mpc85xx: Pass 0 flags to board_init_f
Date: Wed, 30 Apr 2014 10:39:51 -0700	[thread overview]
Message-ID: <53613567.7030502@freescale.com> (raw)
In-Reply-To: <5361350F.1060309@suse.de>

On 04/30/2014 10:38 AM, Alexander Graf wrote:
> 
> On 30.04.14 19:28, York Sun wrote:
>> On 04/30/2014 10:21 AM, Alexander Graf wrote:
>>> The new generic board_init_f has an argument now that takes a number of
>>> prepopulated gd->flags bits. We don't have any, so let's set this to 0.
>>>
>>> Signed-off-by: Alexander Graf <agraf@suse.de>
>>> ---
>>>   arch/powerpc/cpu/mpc85xx/start.S |    1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/powerpc/cpu/mpc85xx/start.S b/arch/powerpc/cpu/mpc85xx/start.S
>>> index 0149146..86883f5 100644
>>> --- a/arch/powerpc/cpu/mpc85xx/start.S
>>> +++ b/arch/powerpc/cpu/mpc85xx/start.S
>>> @@ -1159,6 +1159,7 @@ _start_cont:
>>>   	isync
>>>   
>>>   	bl	cpu_init_f
>>> +	li	r3, 0
>>>   	bl	board_init_f
>>>   	isync
>>>   
>>>
>> I have this patch pending already http://patchwork.ozlabs.org/patch/343618/. I
>> can take either one when merging.
> 
> Ah, sorry, missed that one. The patch is fairly trivial (though 
> debugging it was not - NULL pointer exceptions in printf() are no fun, 
> heh) and you were first, so please just take your patch.
> 
I should CC you to save you the time of debugging. It took me a while to find it.

York

  reply	other threads:[~2014-04-30 17:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-30 17:21 [U-Boot] [PATCH 0/5] PPC 85xx QEMU: Additional fixes Alexander Graf
2014-04-30 17:21 ` [U-Boot] [PATCH 1/5] PPC 85xx QEMU: Always assume 1 core Alexander Graf
2014-04-30 17:21 ` [U-Boot] [PATCH 2/5] PPC 85xx QEMU: Don't use HID1 Alexander Graf
2014-04-30 17:21 ` [U-Boot] [PATCH 3/5] powerpc/mpc85xx: Update TLB CAMs in relocated mode Alexander Graf
2014-04-30 17:21 ` [U-Boot] [PATCH 4/5] powerpc/mpc85xx: Pass 0 flags to board_init_f Alexander Graf
2014-04-30 17:28   ` York Sun
2014-04-30 17:38     ` Alexander Graf
2014-04-30 17:39       ` York Sun [this message]
2014-04-30 17:21 ` [U-Boot] [PATCH 5/5] PPC 85xx QEMU: Make a generic board file Alexander Graf
2014-05-13 16:40 ` [U-Boot] [PATCH 0/5] PPC 85xx QEMU: Additional fixes York Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53613567.7030502@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox