From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/8] kmp204x: Add support for the unit LEDs
Date: Thu, 1 May 2014 08:47:11 -0700 [thread overview]
Message-ID: <53626C7F.6010403@freescale.com> (raw)
In-Reply-To: <53625390.6060105@keymile.com>
On 05/01/2014 07:00 AM, Valentin Longchamp wrote:
> Hi York,
>
> On 04/30/2014 07:04 PM, York Sun wrote:
>> On 04/30/2014 06:01 AM, Valentin Longchamp wrote:
>>> From: Stefan Bigler <stefan.bigler@keymile.com>
>>
>> <snip>
>>
>>> diff --git a/board/keymile/kmp204x/qrio.c b/board/keymile/kmp204x/qrio.c
>>> index 49f9aa2..11949f4 100644
>>> --- a/board/keymile/kmp204x/qrio.c
>>> +++ b/board/keymile/kmp204x/qrio.c
>>> @@ -144,3 +144,17 @@ void qrio_prstcfg(u8 bit, u8 mode)
>>>
>>> out_be32(qrio_base + PRSTCFG_OFF, prstcfg);
>>> }
>>> +
>>> +#define CTRLH_OFF 0x02
>>> +#define CTRLH_WRL_BOOT 0x01
>>> +#define CTRLH_WRL_UNITRUN 0x02
>>> +
>>> +void qrio_set_leds(void)
>>> +{
>>> + u8 ctrlh;
>>> + void __iomem *qrio_base = (void *)CONFIG_SYS_QRIO_BASE;
>>
>> Please insert a blank line here.
>
> OK, that's correct. Do you want me to resend the whole series or are the first 2
> patches with the additional blank line OK ?
>
For a simple change like this, you can do either way. Make sure to change the
subject prefix so it doesn't confuse me or anyone.
York
next prev parent reply other threads:[~2014-05-01 15:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 13:01 [U-Boot] [PATCH 0/8] kmp204x patches for 2014.07 Valentin Longchamp
2014-04-30 13:01 ` [U-Boot] [PATCH 1/8] kmp204x: Add support for the unit LEDs Valentin Longchamp
2014-04-30 17:04 ` York Sun
2014-05-01 14:00 ` Valentin Longchamp
2014-05-01 15:47 ` York Sun [this message]
2014-05-02 8:48 ` [U-Boot] [PATCH v2 " Valentin Longchamp
2014-04-30 13:01 ` [U-Boot] [PATCH 2/8] kmp204x: handle dip-switch for factory settings Valentin Longchamp
2014-04-30 17:04 ` York Sun
2014-05-02 8:49 ` [U-Boot] [PATCH v2 " Valentin Longchamp
2014-04-30 13:01 ` [U-Boot] [PATCH 3/8] kmp204x: selftest/factory test pin support Valentin Longchamp
2014-04-30 13:01 ` [U-Boot] [PATCH 4/8] kmp204x: update the CONFIG_PRAM and CONFIG_KM_RESERVED_PRAM defines Valentin Longchamp
2014-04-30 13:01 ` [U-Boot] [PATCH 5/8] kmp204x: complete the reset sequence and PRST configuration Valentin Longchamp
2014-04-30 13:01 ` [U-Boot] [PATCH 6/8] kmp204x: update the RCW Valentin Longchamp
2014-04-30 13:01 ` [U-Boot] [PATCH 7/8] kmp204x: add workaround for A-004849 Valentin Longchamp
2014-04-30 13:01 ` [U-Boot] [PATCH 8/8] kmp204x: enable the errata command Valentin Longchamp
2014-05-13 16:38 ` [U-Boot] [PATCH 0/8] kmp204x patches for 2014.07 York Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53626C7F.6010403@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox