From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Thu, 01 May 2014 14:00:23 -0600 Subject: [U-Boot] [PATCH 3/8] ums: remove error-checking of MMC device size In-Reply-To: <1398892402-9816-3-git-send-email-swarren@wwwdotorg.org> References: <1398892402-9816-1-git-send-email-swarren@wwwdotorg.org> <1398892402-9816-3-git-send-email-swarren@wwwdotorg.org> Message-ID: <5362A7D7.7070009@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/30/2014 03:13 PM, Stephen Warren wrote: > From: Stephen Warren > > There's no reason to believe that an MMC device will incorrectly report > its capacity. Remove error checking of this value from ums_disk_init() > to simplify it. Hmm. I guess this check might trigger if you tried to export an SD card slot over UMS, yet there was no SD card present. Still, patch 6/8 in this series resolves this, since at least for MMC devices, get_device() calls mmc_init() internally, and hence returns an error in this case. This is more direct that checking the device size.