From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Mon, 05 May 2014 11:08:25 +0200 Subject: [U-Boot] [PATCH 04/12] spl: consolidate arch/arm/include/asm/arch-*/spl.h In-Reply-To: <20140430143926.768C.AA925319@jp.panasonic.com> References: <1398716258-8420-1-git-send-email-tharvey@gateworks.com> <1398716258-8420-5-git-send-email-tharvey@gateworks.com> <20140430143926.768C.AA925319@jp.panasonic.com> Message-ID: <53675509.4070900@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tim, On 30/04/2014 07:39, Masahiro Yamada wrote: > Hi Tim, > Cc : Stefano, Tom > > On Mon, 28 Apr 2014 13:17:30 -0700 > Tim Harvey wrote: > >> From: Masahiro Yamada >> >> arch/arm/include/asm/spl.h requires all SoCs to have >> arch/arm/include/asm/arch-*/spl.h. >> >> But many of them just define BOOT_DEVICE_* macros. >> >> Those macros are used in the "switch (boot_device) { ... }" >> statement in common/spl/spl.c. >> >> So they should not be archtecture specific, but be described as >> a simpile enumeration. >> >> This commit merges most of arch/arm/include/asm/arch-*/spl.h >> into arch/arm/include/asm/spl.h. >> >> With a little more effort, arch-zynq/spl.h and arch-socfpga/spl.h >> will be merged, while I am not sure about OMAP and Exynos. >> >> Signed-off-by: Masahiro Yamada >> Cc: Tom Rini >> Cc: Michal Simek >> Cc: Andreas Biesmann >> Cc: Stephen Warren >> Cc: Tom Warren >> CC: Stefano Babic >> CC: Minkyu Kang >> Cc: Dinh Nguyen >> Acked-by: Andreas Biesmann >> Acked-by: Michal Simek >> Acked-by: Stefano Babic >> Acked-by: Stephen Warren >> Acked-by: Tim Harvey >> Tested-by: Bo Shen [on sama5d3xek board for at91 part] >> Acked-by: Stephen Warren >> Signed-off-by: Tim Harvey > > I understand my patch is here because your series uses > it as a prerequisite. > > But, please make sure this patch should be reviewed and > applied by Tom Rini because this patch is relevant to > various SoCs. > Indeed. Tim, it is enough you add in the cover letter for the next version that your patchset depends on Masahiro's patch, without including it in your series. I will check by merging if all dependencies will be satisfied. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================