public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 7/8] ums: move all variable declarations to the start of the block
Date: Mon, 05 May 2014 10:33:03 -0600	[thread overview]
Message-ID: <5367BD3F.6030401@wwwdotorg.org> (raw)
In-Reply-To: <536756FD.4090009@samsung.com>

On 05/05/2014 03:16 AM, Przemyslaw Marczak wrote:
...
>>>>> On Wednesday, April 30, 2014 at 11:13:21 PM, Stephen Warren wrote:
>>>>>> It's easier to assign values to the variables inside an if
>>>>>> statement body if the assignment and declaration are separate.
...
>> FWIW, I have applied that series locally and rebased my patches on top
>> of it. If you want to see the latest version, feel free to look at:
>>
>> git://github.com/swarren/u-boot.git tegra_dev
...
> I tested your tegra_dev branch on trats2 and also on goni(after apply
> the rest of Mateusz Zalega patches) and it works fine.
> 
> So for this patch set:
> Acked-by: Przemyslaw Marczak <p.marczak@samsung.com>

Good new:-) Thanks for the testing.

  reply	other threads:[~2014-05-05 16:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-30 21:13 [U-Boot] [PATCH 1/8] ums: support block devices not MMC devices Stephen Warren
2014-04-30 21:13 ` [U-Boot] [PATCH 2/8] ums: remove UMS_{NUM, START}_SECTORS + UMS_START_SECTOR Stephen Warren
2014-04-30 21:13 ` [U-Boot] [PATCH 3/8] ums: remove error-checking of MMC device size Stephen Warren
2014-05-01 20:00   ` Stephen Warren
2014-04-30 21:13 ` [U-Boot] [PATCH 4/8] ums: remove ums_disk_init() Stephen Warren
2014-04-30 21:13 ` [U-Boot] [PATCH 5/8] ums: move IO support code to common location Stephen Warren
2014-04-30 21:13 ` [U-Boot] [PATCH 6/8] ums: use get_device() not find_mmc_device(); Stephen Warren
2014-04-30 21:13 ` [U-Boot] [PATCH 7/8] ums: move all variable declarations to the start of the block Stephen Warren
2014-05-01 10:51   ` Marek Vasut
2014-05-01 16:58     ` Stephen Warren
2014-05-01 19:43       ` Lukasz Majewski
2014-05-01 21:47         ` Stephen Warren
2014-05-05  9:16           ` Przemyslaw Marczak
2014-05-05 16:33             ` Stephen Warren [this message]
2014-05-02  4:45       ` Marek Vasut
2014-04-30 21:13 ` [U-Boot] [PATCH 8/8] ums: allow the user to specify the device type Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5367BD3F.6030401@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox