public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i2c: zynq: Fixed compilation errors when using DEBUG
Date: Tue, 06 May 2014 14:00:48 +0200	[thread overview]
Message-ID: <5368CEF0.8080804@denx.de> (raw)
In-Reply-To: <5368C9E2.3080005@monstr.eu>

Hello Michael,

Am 06.05.2014 13:39, schrieb Michal Simek:
> Hi Heiko,
>
> On 04/25/2014 03:46 PM, Michal Simek wrote:
>> From: "Jesper B. Christensen"<jesper.christensen@cobham.com>
>>
>> Signed-off-by: Jesper B. Christensen<jesper.christensen@cobham.com>
>> Signed-off-by: Michal Simek<michal.simek@xilinx.com>
>> ---
>>
>>   drivers/i2c/zynq_i2c.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/i2c/zynq_i2c.c b/drivers/i2c/zynq_i2c.c
>> index f1f6513..b3264af 100644
>> --- a/drivers/i2c/zynq_i2c.c
>> +++ b/drivers/i2c/zynq_i2c.c
>> @@ -142,7 +142,7 @@ static u32 zynq_i2c_wait(struct zynq_i2c_registers *zynq_i2c, u32 mask)
>>   			break;
>>   	}
>>   #ifdef DEBUG
>> -	zynq_i2c_debug_status(zynq_i2c));
>> +	zynq_i2c_debug_status(zynq_i2c);
>>   #endif
>>   	/* Clear interrupt status flags */
>>   	writel(int_status&  mask,&zynq_i2c->interrupt_status);
>> @@ -235,7 +235,7 @@ static int zynq_i2c_read(struct i2c_adapter *adap, u8 dev, uint addr,
>>   	clrbits_le32(&zynq_i2c->control, ZYNQ_I2C_CONTROL_HOLD);
>>
>>   #ifdef DEBUG
>> -	zynq_i2c_debug_status();
>> +	zynq_i2c_debug_status(zynq_i2c);
>>   #endif
>>   	return 0;
>>   }
>> --
>> 1.8.2.3
>>
>
> Can you please add this patch to your i2c custodian repo?

Added it to my ToDo list in patchwork

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

      reply	other threads:[~2014-05-06 12:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-25 13:46 [U-Boot] [PATCH] i2c: zynq: Fixed compilation errors when using DEBUG Michal Simek
2014-05-06 11:39 ` Michal Simek
2014-05-06 12:00   ` Heiko Schocher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5368CEF0.8080804@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox