[U-Boot] [PATCH] i2c: zynq: Fixed compilation errors when using DEBUG

[U-Boot] [PATCH] i2c: zynq: Fixed compilation errors when using DEBUG

[Michal Simek]

From: "Jesper B. Christensen" <jesper.christensen@cobham.com>

Signed-off-by: Jesper B. Christensen <jesper.christensen@cobham.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/i2c/zynq_i2c.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/zynq_i2c.c b/drivers/i2c/zynq_i2c.c
index f1f6513..b3264af 100644
--- a/drivers/i2c/zynq_i2c.c
+++ b/drivers/i2c/zynq_i2c.c
@@ -142,7 +142,7 @@ static u32 zynq_i2c_wait(struct zynq_i2c_registers *zynq_i2c, u32 mask)
 			break;
 	}
 #ifdef DEBUG
-	zynq_i2c_debug_status(zynq_i2c));
+	zynq_i2c_debug_status(zynq_i2c);
 #endif
 	/* Clear interrupt status flags */
 	writel(int_status & mask, &zynq_i2c->interrupt_status);
@@ -235,7 +235,7 @@ static int zynq_i2c_read(struct i2c_adapter *adap, u8 dev, uint addr,
 	clrbits_le32(&zynq_i2c->control, ZYNQ_I2C_CONTROL_HOLD);

 #ifdef DEBUG
-	zynq_i2c_debug_status();
+	zynq_i2c_debug_status(zynq_i2c);
 #endif
 	return 0;
 }
--
1.8.2.3

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140425/caa0f6bf/attachment.pgp>

[U-Boot] [PATCH] i2c: zynq: Fixed compilation errors when using DEBUG

[Michal Simek]

Hi Heiko,

On 04/25/2014 03:46 PM, Michal Simek wrote:
> From: "Jesper B. Christensen" <jesper.christensen@cobham.com>
> 
> Signed-off-by: Jesper B. Christensen <jesper.christensen@cobham.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  drivers/i2c/zynq_i2c.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/zynq_i2c.c b/drivers/i2c/zynq_i2c.c
> index f1f6513..b3264af 100644
> --- a/drivers/i2c/zynq_i2c.c
> +++ b/drivers/i2c/zynq_i2c.c
> @@ -142,7 +142,7 @@ static u32 zynq_i2c_wait(struct zynq_i2c_registers *zynq_i2c, u32 mask)
>  			break;
>  	}
>  #ifdef DEBUG
> -	zynq_i2c_debug_status(zynq_i2c));
> +	zynq_i2c_debug_status(zynq_i2c);
>  #endif
>  	/* Clear interrupt status flags */
>  	writel(int_status & mask, &zynq_i2c->interrupt_status);
> @@ -235,7 +235,7 @@ static int zynq_i2c_read(struct i2c_adapter *adap, u8 dev, uint addr,
>  	clrbits_le32(&zynq_i2c->control, ZYNQ_I2C_CONTROL_HOLD);
> 
>  #ifdef DEBUG
> -	zynq_i2c_debug_status();
> +	zynq_i2c_debug_status(zynq_i2c);
>  #endif
>  	return 0;
>  }
> --
> 1.8.2.3
> 

Can you please add this patch to your i2c custodian repo?

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140506/1fb2d6d4/attachment.pgp>

[U-Boot] [PATCH] i2c: zynq: Fixed compilation errors when using DEBUG

[Heiko Schocher]

Hello Michael,

Am 06.05.2014 13:39, schrieb Michal Simek:
> Hi Heiko,
>
> On 04/25/2014 03:46 PM, Michal Simek wrote:
>> From: "Jesper B. Christensen"<jesper.christensen@cobham.com>
>>
>> Signed-off-by: Jesper B. Christensen<jesper.christensen@cobham.com>
>> Signed-off-by: Michal Simek<michal.simek@xilinx.com>
>> ---
>>
>>   drivers/i2c/zynq_i2c.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/i2c/zynq_i2c.c b/drivers/i2c/zynq_i2c.c
>> index f1f6513..b3264af 100644
>> --- a/drivers/i2c/zynq_i2c.c
>> +++ b/drivers/i2c/zynq_i2c.c
>> @@ -142,7 +142,7 @@ static u32 zynq_i2c_wait(struct zynq_i2c_registers *zynq_i2c, u32 mask)
>>   			break;
>>   	}
>>   #ifdef DEBUG
>> -	zynq_i2c_debug_status(zynq_i2c));
>> +	zynq_i2c_debug_status(zynq_i2c);
>>   #endif
>>   	/* Clear interrupt status flags */
>>   	writel(int_status&  mask,&zynq_i2c->interrupt_status);
>> @@ -235,7 +235,7 @@ static int zynq_i2c_read(struct i2c_adapter *adap, u8 dev, uint addr,
>>   	clrbits_le32(&zynq_i2c->control, ZYNQ_I2C_CONTROL_HOLD);
>>
>>   #ifdef DEBUG
>> -	zynq_i2c_debug_status();
>> +	zynq_i2c_debug_status(zynq_i2c);
>>   #endif
>>   	return 0;
>>   }
>> --
>> 1.8.2.3
>>
>
> Can you please add this patch to your i2c custodian repo?

Added it to my ToDo list in patchwork

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany