[U-Boot] [PATCH] fat: Define MAX_CLUSTSIZE only if not defined in config

[U-Boot] [PATCH] fat: Define MAX_CLUSTSIZE only if not defined in config

[Michal Simek]

From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>

Define MAX_CLUSTSIZE only if not defined in board specific
config file as this size can be decreased to save memory
in some memory constrained cases.

Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 include/fat.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/fat.h b/include/fat.h
index c8eb7cc..1213060 100644
--- a/include/fat.h
+++ b/include/fat.h
@@ -18,7 +18,9 @@
 #define VFAT_MAXSEQ		9   /* Up to 9 of 13 2-byte UTF-16 entries */
 #define PREFETCH_BLOCKS		2

+#ifndef MAX_CLUSTSIZE
 #define MAX_CLUSTSIZE	65536
+#endif
 #define DIRENTSPERBLOCK	(mydata->sect_size / sizeof(dir_entry))
 #define DIRENTSPERCLUST	((mydata->clust_size * mydata->sect_size) / \
 			 sizeof(dir_entry))
--
1.8.2.3

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140425/20b22cc3/attachment.pgp>

[U-Boot] [PATCH] fat: Define MAX_CLUSTSIZE only if not defined in config

[Michal Simek]

Hi Tom,

On 04/25/2014 03:48 PM, Michal Simek wrote:
> From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
> 
> Define MAX_CLUSTSIZE only if not defined in board specific
> config file as this size can be decreased to save memory
> in some memory constrained cases.
> 
> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  include/fat.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/fat.h b/include/fat.h
> index c8eb7cc..1213060 100644
> --- a/include/fat.h
> +++ b/include/fat.h
> @@ -18,7 +18,9 @@
>  #define VFAT_MAXSEQ		9   /* Up to 9 of 13 2-byte UTF-16 entries */
>  #define PREFETCH_BLOCKS		2
> 
> +#ifndef MAX_CLUSTSIZE
>  #define MAX_CLUSTSIZE	65536
> +#endif
>  #define DIRENTSPERBLOCK	(mydata->sect_size / sizeof(dir_entry))
>  #define DIRENTSPERCLUST	((mydata->clust_size * mydata->sect_size) / \
>  			 sizeof(dir_entry))
> --
> 1.8.2.3
> 

Any problem with this patch?

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140506/92a9e1bb/attachment.pgp>

[U-Boot] [PATCH] fat: Define MAX_CLUSTSIZE only if not defined in config

[Tom Rini]

On Fri, Apr 25, 2014 at 03:48:04PM +0200, Michal Simek wrote:

> From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
> 
> Define MAX_CLUSTSIZE only if not defined in board specific
> config file as this size can be decreased to save memory
> in some memory constrained cases.
> 
> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  include/fat.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/fat.h b/include/fat.h
> index c8eb7cc..1213060 100644
> --- a/include/fat.h
> +++ b/include/fat.h
> @@ -18,7 +18,9 @@
>  #define VFAT_MAXSEQ		9   /* Up to 9 of 13 2-byte UTF-16 entries */
>  #define PREFETCH_BLOCKS		2
> 
> +#ifndef MAX_CLUSTSIZE
>  #define MAX_CLUSTSIZE	65536
> +#endif
>  #define DIRENTSPERBLOCK	(mydata->sect_size / sizeof(dir_entry))
>  #define DIRENTSPERCLUST	((mydata->clust_size * mydata->sect_size) / \
>  			 sizeof(dir_entry))

Sorry for the delay.  This should be CONFIG_FS_FAT_MAX_CLUSTSIZE and
documented in the README.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140512/aa3e467d/attachment.pgp>