public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Troy Kisky <troy.kisky@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dwc_ahsata: return failure for MX6 if not IMX6Q
Date: Tue, 06 May 2014 12:55:31 -0700	[thread overview]
Message-ID: <53693E33.5000809@boundarydevices.com> (raw)
In-Reply-To: <1399353758-1351-1-git-send-email-tharvey@gateworks.com>

On 5/5/2014 10:22 PM, Tim Harvey wrote:
> The IMX6QUAD/DUAL have SATA, but the IMX6SOLO/DL do not. Return an error
> indicating no such port instead of attempting a memory access that results
> in a data abort and reset. This dynamic detection is necessary for bootloaders
> that support multiple variants of the IMX6 SoC.
> 
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
>  drivers/block/dwc_ahsata.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/block/dwc_ahsata.c b/drivers/block/dwc_ahsata.c
> index 3569214..638a585 100644
> --- a/drivers/block/dwc_ahsata.c
> +++ b/drivers/block/dwc_ahsata.c
> @@ -17,6 +17,7 @@
>  #include <asm/io.h>
>  #include <linux/bitops.h>
>  #include <asm/arch/clock.h>
> +#include <asm/arch/sys_proto.h>
>  #include "dwc_ahsata.h"
>  
>  struct sata_port_regs {
> @@ -558,6 +559,12 @@ int init_sata(int dev)
>  	u32 linkmap;
>  	struct ahci_probe_ent *probe_ent = NULL;
>  
> +#if defined(CONFIG_MX6)
> +	if (!is_cpu_type(MXC_CPU_MX6Q)) {

&& !is_cpu_type(MXC_CPU_MX6D)


is needed too ?


Troy

  parent reply	other threads:[~2014-05-06 19:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-06  5:22 [U-Boot] [PATCH] dwc_ahsata: return failure for MX6 if not IMX6Q Tim Harvey
2014-05-06  8:17 ` Stefano Babic
2014-05-06 19:55 ` Troy Kisky [this message]
2014-05-07  3:55   ` Tim Harvey
2014-05-08  5:23 ` [U-Boot] [PATCH v2] dwc_ahsata: return failure for MX6 if not IMX6Q/IMX6D Tim Harvey
2014-06-05 10:46   ` Tim Harvey
2014-06-06  8:18   ` Stefano Babic
2014-05-08  5:24 ` [U-Boot] [PATCH] imx: sata: return failure " Tim Harvey
2014-06-05 10:44   ` Tim Harvey
2014-06-05 10:53     ` Stefano Babic
2014-06-06  8:18     ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53693E33.5000809@boundarydevices.com \
    --to=troy.kisky@boundarydevices.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox