[U-Boot] [PATCH 1/3] samsung: misc: check_keys(), key_pressed() - remove type static.

Minkyu Kang
2014-03-06T06:51:18Z

On 28/02/14 23:30, Przemyslaw Marczak wrote:
> This patch removes type "static" from those functions declaration.
> Now it can be used outside.

outside where?
I think there's no reason to make them to non-static function.
If you want to use it at outside then please send the patch together.

>
> Change-Id: I2244ca3568b73251401e5102f26cc113ea69c1a4
> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
> cc: Minkyu Kang <mk7.kang@samsung.com>
> ---
> board/samsung/common/misc.c | 5 ++---
> include/samsung/misc.h | 4 ++++
> 2 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/board/samsung/common/misc.c b/board/samsung/common/misc.c
> index eb15739..1d6f4e4 100644
> --- a/board/samsung/common/misc.c
> +++ b/board/samsung/common/misc.c
> @@ -15,7 +15,6 @@
> #include <asm/arch/cpu.h>
> #include <asm/arch/gpio.h>
> #include <asm/gpio.h>
> -#include <linux/input.h>
> #include <power/pmic.h>
> #include <mmc.h>
>
> @@ -72,7 +71,7 @@ static int power_key_pressed(u32 reg)
> return !!(status & mask);
> }
>
> -static int key_pressed(int key)
> +int key_pressed(int key)
> {
> int value;
>
> @@ -94,7 +93,7 @@ static int key_pressed(int key)
> return value;
> }
>
> -static int check_keys(void)
> +int check_keys(void)
> {
> int keys = 0;
>
> diff --git a/include/samsung/misc.h b/include/samsung/misc.h
> index ede6c15..47beb1f 100644
> --- a/include/samsung/misc.h
> +++ b/include/samsung/misc.h
> @@ -1,6 +1,8 @@
> #ifndef __SAMSUNG_MISC_COMMON_H__
> #define __SAMSUNG_MISC_COMMON_H__
>
> +#include <linux/input.h>
> +
> #ifdef CONFIG_REVISION_TAG
> u32 get_board_rev(void);
> #endif
> @@ -19,6 +21,8 @@ enum {
> };
>
> void keys_init(void);
> +int check_keys(void);
> +int key_pressed(int key);
> void check_boot_mode(void);
> #endif /* CONFIG_LCD_MENU */
>
>

Thanks,
Minkyu Kang.