From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Wed, 07 May 2014 12:27:56 -0600
Subject: [U-Boot] [PATCH 3/4] mmc: provide a select_hwpart
 implementation for get_device()
In-Reply-To: <CAOMZO5AJY-1D4LjrwL9FJPRML2CJqrfpaoQrWP0qDtwUaMjSHQ@mail.gmail.com>
References: <1399486743-23807-1-git-send-email-swarren@wwwdotorg.org>	<1399486743-23807-3-git-send-email-swarren@wwwdotorg.org>
	<CAOMZO5AJY-1D4LjrwL9FJPRML2CJqrfpaoQrWP0qDtwUaMjSHQ@mail.gmail.com>
Message-ID: <536A7B2C.2020507@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 05/07/2014 12:22 PM, Fabio Estevam wrote:
> On Wed, May 7, 2014 at 3:19 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> 
>> +int mmc_select_hwpart(int dev_num, int hwpart)
...
>> +       ret = mmc_switch_part(dev_num, hwpart);
>> +       if (ret)
>> +               return -1;
> 
> Can't you return more appropriate return values rather than -1?

Oh yes, I should return ret there. I'll hold off for a while before
posting V2 though.