[U-Boot] [PATCH] zynq: add empty xil_io.h to avoid compile error

[U-Boot] [PATCH] zynq: add empty xil_io.h to avoid compile error

[Masahiro Yamada]

ps7_init.c exported by hw project has #include "xil_io.h" line
but U-Boot does not have "xil_io.h".

So we get an error on SPL build:
  ps7_init.c:12581:20: fatal error: xil_io.h: No such file or directory

We can delete the include directive in ps7_init.c to avoid this error.
But it is painful to do this every time we export ps7_init.c file.

Instead, we can put an empty xil_io.h in the same directory
so we can directly copy ps7_init.c as is.

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: Michal Simek <michal.simek@xilinx.com>
---
 board/xilinx/zynq/xil_io.h | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 board/xilinx/zynq/xil_io.h

diff --git a/board/xilinx/zynq/xil_io.h b/board/xilinx/zynq/xil_io.h
new file mode 100644
index 0000000..e59a977
--- /dev/null
+++ b/board/xilinx/zynq/xil_io.h
@@ -0,0 +1,13 @@
+/*
+ * SPDX-License-Identifier:    GPL-2.0+
+ */
+
+#ifndef XIL_IO_H           /* prevent circular inclusions */
+#define XIL_IO_H
+
+/*
+ * This empty file is here because ps7_init.c exported by hw project
+ * has #include "xil_io.h" line.
+ */
+
+#endif /* XIL_IO_H */
-- 
1.8.3.2

[U-Boot] [PATCH] zynq: add empty xil_io.h to avoid compile error

[Michal Simek]

On 05/08/2014 10:13 AM, Masahiro Yamada wrote:
> ps7_init.c exported by hw project has #include "xil_io.h" line
> but U-Boot does not have "xil_io.h".
> 
> So we get an error on SPL build:
>   ps7_init.c:12581:20: fatal error: xil_io.h: No such file or directory
> 
> We can delete the include directive in ps7_init.c to avoid this error.
> But it is painful to do this every time we export ps7_init.c file.
> 
> Instead, we can put an empty xil_io.h in the same directory
> so we can directly copy ps7_init.c as is.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> ---
>  board/xilinx/zynq/xil_io.h | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>  create mode 100644 board/xilinx/zynq/xil_io.h
> 
> diff --git a/board/xilinx/zynq/xil_io.h b/board/xilinx/zynq/xil_io.h
> new file mode 100644
> index 0000000..e59a977
> --- /dev/null
> +++ b/board/xilinx/zynq/xil_io.h
> @@ -0,0 +1,13 @@
> +/*
> + * SPDX-License-Identifier:    GPL-2.0+
> + */
> +
> +#ifndef XIL_IO_H           /* prevent circular inclusions */
> +#define XIL_IO_H
> +
> +/*
> + * This empty file is here because ps7_init.c exported by hw project
> + * has #include "xil_io.h" line.
> + */
> +
> +#endif /* XIL_IO_H */
> 

This is good if this is acceptable by others.

Acked-by: Michal Simek <monstr@monstr.eu>

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140508/f89d82ef/attachment.pgp>

[U-Boot] [PATCH] zynq: add empty xil_io.h to avoid compile error

[Tom Rini]

On Thu, May 08, 2014 at 10:29:25AM +0200, Michal Simek wrote:
> On 05/08/2014 10:13 AM, Masahiro Yamada wrote:
> > ps7_init.c exported by hw project has #include "xil_io.h" line
> > but U-Boot does not have "xil_io.h".
> > 
> > So we get an error on SPL build:
> >   ps7_init.c:12581:20: fatal error: xil_io.h: No such file or directory
> > 
> > We can delete the include directive in ps7_init.c to avoid this error.
> > But it is painful to do this every time we export ps7_init.c file.
> > 
> > Instead, we can put an empty xil_io.h in the same directory
> > so we can directly copy ps7_init.c as is.
> > 
> > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> > Cc: Michal Simek <michal.simek@xilinx.com>
> > ---
> >  board/xilinx/zynq/xil_io.h | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> >  create mode 100644 board/xilinx/zynq/xil_io.h
> > 
> > diff --git a/board/xilinx/zynq/xil_io.h b/board/xilinx/zynq/xil_io.h
> > new file mode 100644
> > index 0000000..e59a977
> > --- /dev/null
> > +++ b/board/xilinx/zynq/xil_io.h
> > @@ -0,0 +1,13 @@
> > +/*
> > + * SPDX-License-Identifier:    GPL-2.0+
> > + */
> > +
> > +#ifndef XIL_IO_H           /* prevent circular inclusions */
> > +#define XIL_IO_H
> > +
> > +/*
> > + * This empty file is here because ps7_init.c exported by hw project
> > + * has #include "xil_io.h" line.
> > + */
> > +
> > +#endif /* XIL_IO_H */
> > 
> 
> This is good if this is acceptable by others.
> 
> Acked-by: Michal Simek <monstr@monstr.eu>

I can live with this too.

Acked-by: Tom Rini <trini@ti.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140509/43b96ae3/attachment.pgp>