public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Michal Simek <monstr@monstr.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] zynq: ignore ps7_init.h
Date: Thu, 08 May 2014 14:00:07 +0200	[thread overview]
Message-ID: <536B71C7.9090907@monstr.eu> (raw)
In-Reply-To: <20140508182122.E091.AA925319@jp.panasonic.com>

On 05/08/2014 11:21 AM, Masahiro Yamada wrote:
> Hi Michal,
> 
>>
>> Here is just one question if we should also ignore ps7_init.c too.
>> It means move current ps7_init weak function to spl.c in mach-zynq
>> and just compile ps7_init.c in board file if it is available there.
>>
>> Is there any nice hook in Kbuild to compile file if it is available?
>>
>> Something like
>> [ -f ps7_init.c ] && compile it
> 
> Nice suggestion!
> 
> 
>> Then we can just move weak function
>> and ignore ps7_init.c/h files in board file.
>>
> 
> This might not be beautiful very much, but
> we can write board/xilinx/zynq/Makefile like this:
> 
> obj-y	:= board.o
> obj-$(CONFIG_SPL_BUILD)	+= $(if $(wildcard $(srctree)/$(src)/ps7_init.c),ps7_init.o)

If this is acceptable by others I am quite happy to use it
because it seems to me like a good way how to handle it.

In future when everything is ready I expect that these ps7_init.c/h
files will go away and information will be read directly from DTS
but we are not there yet.

Anyway: Can you please prepare that patches? I am quite happy to test them
and adding it to my zynq queue and send it to Albert.

Or do you want me to prepare them?

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140508/e17bb3c5/attachment.pgp>

  reply	other threads:[~2014-05-08 12:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-08  8:13 [U-Boot] [PATCH] zynq: ignore ps7_init.h Masahiro Yamada
2014-05-08  8:27 ` Michal Simek
2014-05-08  9:21   ` Masahiro Yamada
2014-05-08 12:00     ` Michal Simek [this message]
2014-05-08 12:32       ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536B71C7.9090907@monstr.eu \
    --to=monstr@monstr.eu \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox