From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Mon, 12 May 2014 09:09:57 +0200 Subject: [U-Boot] [PATCH 3/4] lib, fdt: move fdtdec_get_int() out of lib/fdtdec.c In-Reply-To: References: <1399547118-5136-1-git-send-email-hs@denx.de> <1399547118-5136-4-git-send-email-hs@denx.de> Message-ID: <537073C5.8010105@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Simon, Am 09.05.2014 21:59, schrieb Simon Glass: > Hi Heiko, > > On 8 May 2014 05:05, Heiko Schocher wrote: >> move fdtdec_get_int() out of lib/fdtdec.c into lib/fdtdec_common.c >> as this function is also used, if CONFIG_OF_CONTROL is not >> used. Poped up on the ids8313 board using signed FIT images, >> and activating CONFIG_SYS_GENERIC_BOARD. Without this patch >> it shows on boot: >> >> No valid FDT found - please append one to U-Boot binary, use u-boot-dtb.bin or define CONFIG_OF_EMBED. For sandbox, use -d >> >> With this patch, it boots again with CONFIG_SYS_GENERIC_BOARD >> enabled. >> >> Signed-off-by: Heiko Schocher >> Cc: Simon Glass >> Cc: Tom Rini > > What is the reason why we can't have a common function? Is it because > of the s32 type? I removed the two implementations and used now only: int fdtdec_get_int(const void *blob, int node, const char *prop_name, int default_val) { const int *cell; int len; cell = fdt_getprop_w((void *)blob, node, prop_name, &len); if (cell && len >= sizeof(int)) { int val = fdt32_to_cpu(cell[0]); return val; } return default_val; } in lib/fdtdec_common.c. I see no compiler error/warnings for the ids8313 board and the tools for host and target side ... so if this is OK for you, I can send a v2. bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany