public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc/mpc85xx: 32bit DDR changes for P1020/P1011
Date: Tue, 13 May 2014 08:07:31 -0700	[thread overview]
Message-ID: <53723533.4000702@freescale.com> (raw)
In-Reply-To: <1399960252-4693-1-git-send-email-prabhakar@freescale.com>

On 05/12/2014 10:50 PM, Prabhakar Kushwaha wrote:
> The P1020/P1011 SOCs support max 32bit DDR width as opposed to P2020/P2010
> where max DDR data width supported is 64bit.
> 
> Add dynamic DDR size adjustment in second stage boot loader execution.
> 
> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> ---
>  arch/powerpc/cpu/mpc85xx/cpu.c |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/cpu/mpc85xx/cpu.c b/arch/powerpc/cpu/mpc85xx/cpu.c
> index 12e8e10..9c082b4 100644
> --- a/arch/powerpc/cpu/mpc85xx/cpu.c
> +++ b/arch/powerpc/cpu/mpc85xx/cpu.c
> @@ -347,7 +347,12 @@ phys_size_t initdram(int board_type)
>  	defined(CONFIG_QEMU_E500)
>  	return fsl_ddr_sdram_size();
>  #else
> -	return (phys_size_t)CONFIG_SYS_SDRAM_SIZE * 1024 * 1024;
> +	struct cpu_type *cpu = gd->arch.cpu;
> +	/* P1020 and it's derivatives support max 32bit DDR width */
> +	if (cpu->soc_ver == SVR_P1020 || cpu->soc_ver == SVR_P1011)
> +		return CONFIG_SYS_SDRAM_SIZE * 1024 * 1024 / 2;
> +	else
> +		return CONFIG_SYS_SDRAM_SIZE * 1024 * 1024;
>  #endif
>  }
>  #else /* CONFIG_SYS_RAMBOOT */
> 

Prabhakar,

The second stage boot loader doesn't re-initialize DDR, right? The size should
come from either fsl_ddr_sdram_size() or the predefined macro
CONFIG_SYS_SDRAM_SIZE. It looks like you are modifying the predefiend one. Is
this what you want? If so, why don't you defined the macro with correct value?

York

      reply	other threads:[~2014-05-13 15:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-13  5:50 [U-Boot] [PATCH] powerpc/mpc85xx: 32bit DDR changes for P1020/P1011 Prabhakar Kushwaha
2014-05-13 15:07 ` York Sun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53723533.4000702@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox