* [U-Boot] Signed-off-by rules for U-Boot
@ 2014-05-13 18:03 Stephen Warren
2014-05-13 18:14 ` Stefano Babic
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Warren @ 2014-05-13 18:03 UTC (permalink / raw)
To: u-boot
Does U-Boot follow the same Signed-off-by procedures as the Linux
kernel, or is s-o-b only relevant in U-Boot for the initial patch
submitter, and not maintainers?
I ask because there are a bunch of patches of mine that got applied
without the maintainer adding their S-o-b when applying them, which
would be very unusual for Linux, but perhaps it's normal for U-Boot?
Some likely non-exhaustive examples are:
2813006fecda usb: ci_udc: allow multiple buffer allocs per ep
66b88b07cdab usb: ums: add error handling for failed registration
264e0e591bbd config: enable CMD_BMP when API+LCD is enabled
53eb768dfb97 aes: make apply_cbc_chain_data non-static
Yet others did get a maintainer s-o-b:
d381294aef4a ARM: tegra: pack pinmux data tables tighter
def816a2ba87 mmc: set rca to 1 for MMC cards
91171091c673 ARM: tegra: make use of negative ENV_OFFSET on NVIDIA...
6ab6a650a418 disk: initialize name/part fields when returning a whole...
c75942c7b792 sf: winbond: fix page_size
It seems like it mostly varies by maintainer.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [U-Boot] Signed-off-by rules for U-Boot
2014-05-13 18:03 [U-Boot] Signed-off-by rules for U-Boot Stephen Warren
@ 2014-05-13 18:14 ` Stefano Babic
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Babic @ 2014-05-13 18:14 UTC (permalink / raw)
To: u-boot
Hi Stephen,
On 13/05/2014 20:03, Stephen Warren wrote:
> Does U-Boot follow the same Signed-off-by procedures as the Linux
> kernel, or is s-o-b only relevant in U-Boot for the initial patch
> submitter, and not maintainers?
>
Yes, we discussed this in a previous thread, here Wolfgang's answer:
http://lists.denx.de/pipermail/u-boot/2012-October/137248.html
> I ask because there are a bunch of patches of mine that got applied
> without the maintainer adding their S-o-b when applying them, which
> would be very unusual for Linux, but perhaps it's normal for U-Boot?
>
It should be normal for U-Boot. I never add my s-o-b to patches that I
only merge. Only if I change something I add my s-o-b. If this is not
the right rule, I am doing wrong since a lot of time ;-).
> Some likely non-exhaustive examples are:
>
> 2813006fecda usb: ci_udc: allow multiple buffer allocs per ep
> 66b88b07cdab usb: ums: add error handling for failed registration
> 264e0e591bbd config: enable CMD_BMP when API+LCD is enabled
> 53eb768dfb97 aes: make apply_cbc_chain_data non-static
>
> Yet others did get a maintainer s-o-b:
>
> d381294aef4a ARM: tegra: pack pinmux data tables tighter
> def816a2ba87 mmc: set rca to 1 for MMC cards
> 91171091c673 ARM: tegra: make use of negative ENV_OFFSET on NVIDIA...
> 6ab6a650a418 disk: initialize name/part fields when returning a whole...
> c75942c7b792 sf: winbond: fix page_size
>
> It seems like it mostly varies by maintainer.
Agree we should be consistent. I am not aware that the original rule was
changed, even if the behavior is different as the Linux kernel.
Regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-13 18:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-13 18:03 [U-Boot] Signed-off-by rules for U-Boot Stephen Warren
2014-05-13 18:14 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox