From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Signed-off-by rules for U-Boot
Date: Tue, 13 May 2014 20:14:41 +0200 [thread overview]
Message-ID: <53726111.7000006@denx.de> (raw)
In-Reply-To: <53725E6B.9020502@wwwdotorg.org>
Hi Stephen,
On 13/05/2014 20:03, Stephen Warren wrote:
> Does U-Boot follow the same Signed-off-by procedures as the Linux
> kernel, or is s-o-b only relevant in U-Boot for the initial patch
> submitter, and not maintainers?
>
Yes, we discussed this in a previous thread, here Wolfgang's answer:
http://lists.denx.de/pipermail/u-boot/2012-October/137248.html
> I ask because there are a bunch of patches of mine that got applied
> without the maintainer adding their S-o-b when applying them, which
> would be very unusual for Linux, but perhaps it's normal for U-Boot?
>
It should be normal for U-Boot. I never add my s-o-b to patches that I
only merge. Only if I change something I add my s-o-b. If this is not
the right rule, I am doing wrong since a lot of time ;-).
> Some likely non-exhaustive examples are:
>
> 2813006fecda usb: ci_udc: allow multiple buffer allocs per ep
> 66b88b07cdab usb: ums: add error handling for failed registration
> 264e0e591bbd config: enable CMD_BMP when API+LCD is enabled
> 53eb768dfb97 aes: make apply_cbc_chain_data non-static
>
> Yet others did get a maintainer s-o-b:
>
> d381294aef4a ARM: tegra: pack pinmux data tables tighter
> def816a2ba87 mmc: set rca to 1 for MMC cards
> 91171091c673 ARM: tegra: make use of negative ENV_OFFSET on NVIDIA...
> 6ab6a650a418 disk: initialize name/part fields when returning a whole...
> c75942c7b792 sf: winbond: fix page_size
>
> It seems like it mostly varies by maintainer.
Agree we should be consistent. I am not aware that the original rule was
changed, even if the behavior is different as the Linux kernel.
Regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
prev parent reply other threads:[~2014-05-13 18:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 18:03 [U-Boot] Signed-off-by rules for U-Boot Stephen Warren
2014-05-13 18:14 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53726111.7000006@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox