From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/4] bootm: make use of legacy image format configurable
Date: Thu, 15 May 2014 07:47:48 +0200 [thread overview]
Message-ID: <53745504.2030709@denx.de> (raw)
In-Reply-To: <53735086.5060901@monstr.eu>
Hello Michal,
Am 14.05.2014 13:16, schrieb Michal Simek:
> On 05/14/2014 12:54 PM, Heiko Schocher wrote:
>> make the use of legacy image format configurable through
>> the config define CONFIG_IMAGE_FORMAT_LEGACY.
>>
>> When relying on signed FIT images with required signature check
>> the legacy image format should be disabled. Therefore introduce
>> this new define and enable legacy image format if CONFIG_FIT_SIGNATURE
>> is not set. If CONFIG_FIT_SIGNATURE is set disable per default
>> the legacy image format.
>>
>> Signed-off-by: Heiko Schocher<hs@denx.de>
>> Cc: Simon Glass<sjg@chromium.org>
>> Cc: Lars Steubesand<lars.steubesand@philips.com>
>> Cc: Mike Pearce<mike@kaew.be>
>> Cc: Wolfgang Denk<wd@denx.de>
>> Cc: Tom Rini<trini@ti.com>
>> Cc: Michal Simek<monstr@monstr.eu>
>> Cc: Michael Conrad<Michael.Conrad@ids.de>
>>
>> ---
>> - changes for v2:
>> - make the legacy image format configurable through
>> the define CONFIG_IMAGE_FORMAT_LEGACY.
>>
>> Default:
>> if not CONFIG_FIT_SIGNATURE is defined it is enabled,
>> else disabled.
>>
>> Disable it with CONFIG_DISABLE_IMAGE_LEGACY if
>> CONFIG_FIT_SIGNATURE is not defined.
>
> Just a note that ifdef CONFIG_IMAGE_FORMAT_LEGACY
> should be also used in SPL code.
I think thats the case, as I did the default settings in
include/config_defaults.h and a MAKEALL for arm and powerpc
dropped no compiler errors/warnings.
This is just a first step to deactivate legacy image format.
A complete remove patch of it needs more work/time ...
> But that means that FIT image with signature feature
> should be enabled for SPL.
Why?
> If possible please also enable CONFIG_IMAGE_FORMAT_LEGACY
> for zynq because we are using legacy formats too.
You mean in "include/configs/zynq-common.h" ?
Prepared this for v3, but I could not test it...
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2014-05-15 5:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 10:54 [U-Boot] [PATCH v2 0/4] mpc8313: ids8313 board updates Heiko Schocher
2014-05-14 10:54 ` [U-Boot] [PATCH v2 1/4] bootm: make use of legacy image format configurable Heiko Schocher
2014-05-14 11:16 ` Michal Simek
2014-05-15 5:47 ` Heiko Schocher [this message]
2014-05-15 8:54 ` Michal Simek
2014-05-14 10:54 ` [U-Boot] [PATCH v2 2/4] mpc8313, signed fit: enable legacy image format on ids8313 board Heiko Schocher
2014-05-14 10:54 ` [U-Boot] [PATCH v2 3/4] lib, fdt: move fdtdec_get_int() out of lib/fdtdec.c Heiko Schocher
2014-05-15 1:49 ` Simon Glass
2014-05-15 5:53 ` Heiko Schocher
2014-05-14 10:54 ` [U-Boot] [PATCH v2 4/4] mpc8313: add CONFIG_SYS_GENERIC_BOARD to ids8313 board Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53745504.2030709@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).