From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bo Shen <voice.shen@atmel.com>
Date: Fri, 16 May 2014 16:29:54 +0800
Subject: [U-Boot] [PATCH 2/2] ARMv7: at91: enable ICache and DCache.
In-Reply-To: <1400228130-18113-3-git-send-email-josh.wu@atmel.com>
References: <1400228130-18113-1-git-send-email-josh.wu@atmel.com>
	<1400228130-18113-3-git-send-email-josh.wu@atmel.com>
Message-ID: <5375CC82.3010705@atmel.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Josh,

On 05/16/2014 04:15 PM, Josh Wu wrote:
> As SAMA5D3 is a at91 ARMv7 cpu, so we should enable LCD DCache
> flush for SAMA5D3X-EK.
>
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> ---
>   arch/arm/cpu/armv7/at91/cpu.c       |    6 ++++++
>   board/atmel/sama5d3xek/sama5d3xek.c |    6 +++++-
>   2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/cpu/armv7/at91/cpu.c b/arch/arm/cpu/armv7/at91/cpu.c
> index 2fbf60d..6f2164f 100644
> --- a/arch/arm/cpu/armv7/at91/cpu.c
> +++ b/arch/arm/cpu/armv7/at91/cpu.c
> @@ -61,6 +61,12 @@ int print_cpuinfo(void)
>
>   void enable_caches(void)
>   {
> +#ifndef CONFIG_SYS_ICACHE_OFF
> +	icache_enable();
> +#endif

No need this one. Ifdef CONFIG_SYS_ICACHE_OFF, it will be disabled.

> +#ifndef CONFIG_SYS_DCACHE_OFF
> +	dcache_enable();
> +#endif
>   }
>
>   unsigned int get_chip_id(void)
> diff --git a/board/atmel/sama5d3xek/sama5d3xek.c b/board/atmel/sama5d3xek/sama5d3xek.c
> index c835c12..1fc91d9 100644
> --- a/board/atmel/sama5d3xek/sama5d3xek.c
> +++ b/board/atmel/sama5d3xek/sama5d3xek.c
> @@ -200,8 +200,12 @@ int board_init(void)
>   		at91_gmac_hw_init();
>   #endif
>   #ifdef CONFIG_LCD
> -	if (has_lcdc())
> +	if (has_lcdc()) {
>   		sama5d3xek_lcd_hw_init();
> +
> +		/* Enable flushing as we enabled dcache */
> +		lcd_set_flush_dcache(1);

Why not implement in driver, or else, each SoC enable dcache will need 
add this.

> +	}
>   #endif
>   	return 0;
>   }
>

Best Regards,
Bo Shen