[U-Boot] [PATCH] at91: move CONFIG_AT91FAMILY from board config file to hardware.h

public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed

From: Bo Shen <voice.shen@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] at91: move CONFIG_AT91FAMILY from board config file to hardware.h
Date: Fri, 16 May 2014 18:02:16 +0800	[thread overview]
Message-ID: <5375E228.5050401@atmel.com> (raw)
In-Reply-To: <1400230346-32593-1-git-send-email-josh.wu@atmel.com>

Hi Josh,

On 05/16/2014 04:52 PM, Josh Wu wrote:
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> ---
>   arch/arm/include/asm/arch-at91/at91sam9x5.h |    2 ++
>   include/configs/at91sam9m10g45ek.h          |    1 -
>   include/configs/at91sam9n12ek.h             |    1 -
>   include/configs/at91sam9x5ek.h              |    1 -
>   include/configs/sama5d3_xplained.h          |    1 -
>   include/configs/sama5d3xek.h                |    1 -
>   6 files changed, 2 insertions(+), 5 deletions(-)

I think this patch should be split into two patches at least.
One is move the CONFIG_AT91FAMILY to SoC header (while not hardware.h).
The other is to remove multiple times definition CONFIG_AT91FAMILY.

Btw, can you add a little bit words into commit message.

Best Regards,
Bo Shen

> diff --git a/arch/arm/include/asm/arch-at91/at91sam9x5.h b/arch/arm/include/asm/arch-at91/at91sam9x5.h
> index a471038..36a5cdf 100644
> --- a/arch/arm/include/asm/arch-at91/at91sam9x5.h
> +++ b/arch/arm/include/asm/arch-at91/at91sam9x5.h
> @@ -12,6 +12,8 @@
>   #ifndef __AT91SAM9X5_H__
>   #define __AT91SAM9X5_H__
>
> +#define CONFIG_AT91FAMILY	/* it's a member of AT91 family */
> +
>   /*
>    * Peripheral identifiers/interrupts.
>    */
> diff --git a/include/configs/at91sam9m10g45ek.h b/include/configs/at91sam9m10g45ek.h
> index 7a3c9b5..5d5fbe5 100644
> --- a/include/configs/at91sam9m10g45ek.h
> +++ b/include/configs/at91sam9m10g45ek.h
> @@ -22,7 +22,6 @@
>   #define CONFIG_SYS_AT91_MAIN_CLOCK      12000000 /* from 12 MHz crystal */
>
>   #define CONFIG_AT91SAM9M10G45EK
> -#define CONFIG_AT91FAMILY
>
>   #define CONFIG_CMDLINE_TAG		/* enable passing of ATAGs	*/
>   #define CONFIG_SETUP_MEMORY_TAGS
> diff --git a/include/configs/at91sam9n12ek.h b/include/configs/at91sam9n12ek.h
> index e23549d..ebfc26e 100644
> --- a/include/configs/at91sam9n12ek.h
> +++ b/include/configs/at91sam9n12ek.h
> @@ -19,7 +19,6 @@
>   #define CONFIG_SYS_TEXT_BASE		0x26f00000
>
>   #define CONFIG_ARM926EJS
> -#define CONFIG_AT91FAMILY
>
>   /* ARM asynchronous clock */
>   #define CONFIG_SYS_AT91_SLOW_CLOCK	32768		/* slow clock xtal */
> diff --git a/include/configs/at91sam9x5ek.h b/include/configs/at91sam9x5ek.h
> index f0a6757..b2dd252 100644
> --- a/include/configs/at91sam9x5ek.h
> +++ b/include/configs/at91sam9x5ek.h
> @@ -18,7 +18,6 @@
>   #define CONFIG_SYS_AT91_MAIN_CLOCK	12000000	/* 12 MHz crystal */
>
>   #define CONFIG_AT91SAM9X5EK
> -#define CONFIG_AT91FAMILY
>
>   #define CONFIG_CMDLINE_TAG		/* enable passing of ATAGs */
>   #define CONFIG_SETUP_MEMORY_TAGS
> diff --git a/include/configs/sama5d3_xplained.h b/include/configs/sama5d3_xplained.h
> index 41c946d..d7fb850 100644
> --- a/include/configs/sama5d3_xplained.h
> +++ b/include/configs/sama5d3_xplained.h
> @@ -18,7 +18,6 @@
>   #define CONFIG_SYS_AT91_SLOW_CLOCK      32768
>   #define CONFIG_SYS_AT91_MAIN_CLOCK      12000000 /* from 12 MHz crystal */
>
> -#define CONFIG_AT91FAMILY
>   #define CONFIG_ARCH_CPU_INIT
>   #define CONFIG_SKIP_LOWLEVEL_INIT
>   #define CONFIG_BOARD_EARLY_INIT_F
> diff --git a/include/configs/sama5d3xek.h b/include/configs/sama5d3xek.h
> index b509c2d..72f0f27 100644
> --- a/include/configs/sama5d3xek.h
> +++ b/include/configs/sama5d3xek.h
> @@ -21,7 +21,6 @@
>   #define CONFIG_SYS_AT91_SLOW_CLOCK      32768
>   #define CONFIG_SYS_AT91_MAIN_CLOCK      12000000 /* from 12 MHz crystal */
>
> -#define CONFIG_AT91FAMILY
>   #define CONFIG_ARCH_CPU_INIT
>
>   #ifndef CONFIG_SPL_BUILD
>

next prev parent reply	other threads:[~2014-05-16 10:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-16  8:52 [U-Boot] [PATCH] at91: move CONFIG_AT91FAMILY from board config file to hardware.h Josh Wu
2014-05-16 10:02 ` Bo Shen [this message]
2014-05-19  9:36   ` Josh Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5375E228.5050401@atmel.com \
    --to=voice.shen@atmel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox