From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dfu: mmc: return data from raw partition reads
Date: Mon, 19 May 2014 16:07:44 -0600 [thread overview]
Message-ID: <537A80B0.2010105@wwwdotorg.org> (raw)
In-Reply-To: <1400282580-7121-1-git-send-email-swarren@wwwdotorg.org>
On 05/16/2014 05:23 PM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Nothing in dfu_mmc.c ever sets dfu->r_left. Consequently, reads from
> MMC DFU altsettings would return 0 bytes.
>
> Fix this by modifying dfu_read_medium_mmc() to set *len in the same way
> that dfu_nand.c's dfu_read_medium_nand() does.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> Even though this mirrors how dfu_nand.c works, it feels odd to do this
> every time a HW read is performed, since I believe this can happen
> multiple times in a single DFU read transaction. Surely *len (and hence
> dfu->r_left) should be set up once when the altsetting is initialized,
> likely by calling a separate function in struct dfu_entity?
>
> P.S. Could you please add a "dfu" entry into doc/git-mailrc?
Hmm. Scratch this specific patch. While it makes some forms of reads
work, larger reads (e.g. of an entire 4MB boot0 eMMC HW partition) blow
up horribly. If anyone has any pointers on how this is supposed to work,
I'd be interested. I'm not sure that eMMC DFU read has actually been
tested...
prev parent reply other threads:[~2014-05-19 22:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 23:23 [U-Boot] [PATCH] dfu: mmc: return data from raw partition reads Stephen Warren
2014-05-19 22:07 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537A80B0.2010105@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox