From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Tue, 20 May 2014 06:21:05 +0200 Subject: [U-Boot] [PATCH v3 1/4] bootm: make use of legacy image format configurable In-Reply-To: References: <1400476231-24433-1-git-send-email-hs@denx.de> <1400476231-24433-2-git-send-email-hs@denx.de> Message-ID: <537AD831.7000300@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Lars, Am 19.05.2014 16:11, schrieb Steubesand, Lars: > Hi Heiko, > > [snip] >> When relying on signed FIT images with required signature check the >> legacy image format should be disabled. Therefore introduce this new >> define and enable legacy image format if CONFIG_FIT_SIGNATURE is not >> set. If CONFIG_FIT_SIGNATURE is set disable per default the legacy >> image format. > [snip] >> diff --git a/include/config_defaults.h b/include/config_defaults.h >> index >> ad08c1d..fbe0743 100644 >> --- a/include/config_defaults.h >> +++ b/include/config_defaults.h >> @@ -20,4 +20,12 @@ >> #define CONFIG_ZLIB 1 >> #define CONFIG_PARTITIONS 1 >> >> +#ifndef CONFIG_FIT_SIGNATURE >> +#define CONFIG_IMAGE_FORMAT_LEGACY >> +#endif >> + >> +#ifdef CONFIG_DISABLE_IMAGE_LEGACY >> +#undef CONFIG_IMAGE_FORMAT_LEGACY >> +#endif >> + >> #endif > [snip] > > it appears that the config changes in config_defaults.h have actually > not the desired effect since the board specific config file is evaluated > after the config_defaults.h. A proper change most likely needs to be applied > to config_fallbacks.h. Yep, you are completely right! good catch! I prepared a v4 for this issue, and just compiling a MAKEALL for arm and powerpc with the above change. bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany